phoenix/icarus
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 33 Wiki Activity

Code Cleanup #37

New Issue
Closed
opened 2019-05-02 22:50:25 -04:00 by kdeng00 · 0 comments
kdeng00 commented 2019-05-02 22:50:25 -04:00 (Migrated from github.com)
Copy Link
Copy Source

Go through the code and remove things that are not necessary. Will update more on what this entails in the next few days.

  1. Ensure that when a song's attributes or metadata is updated, update the corresponding album and/or artist records
  2. When a song's attributes or metadata has been updated move the song to the proper location on the filesystem
  3. When deleting songs manage the artist and album records
  4. Allow the year property of the Song model to allow null values for the Song table
  5. Create a namespace for the StoreContext classes that are currently part of the Icarus.Models.Context namespace. Create a Repository namespace to place them in
  6. Change all instances of StoreContext to Repository
  7. Change object names of the SongRepository (used to be MusicStoreContext) to songRepository. Do the same with the other StoreContext classes
  8. Reduce build warnings
  9. Version API to 1.0. This will change the HTTP Endpoints from api/[ending]/[endpoint] to /api/v1/[ending]/[endpoint]

Status

Task Completed
1 Yes
2 Yes
3 Yes
4 Yes
5 Yes
6 Yes
7 Yes
8 Yes
9 Yes
Go through the code and remove things that are not necessary. Will update more on what this entails in the next few days. 1. Ensure that when a song's attributes or metadata is updated, update the corresponding album and/or artist records 2. When a song's attributes or metadata has been updated move the song to the proper location on the filesystem 3. When deleting songs manage the artist and album records 4. Allow the year property of the [Song](https://github.com/amazing-username/Icarus/blob/master/Models/Song.cs) model to allow null values for the Song table 5. Create a namespace for the StoreContext classes that are currently part of the Icarus.Models.Context namespace. Create a Repository namespace to place them in 6. Change all instances of *StoreContext* to *Repository* 7. Change object names of the *SongRepository* (used to be *MusicStoreContext*) to songRepository. Do the same with the other StoreContext classes 8. Reduce build warnings 9. Version API to 1.0. This will change the HTTP Endpoints from *api/[ending]/[endpoint]* to */api/v1/[ending]/[endpoint]* ## Status | Task | Completed | | ------------- |:-------------:| |1 | Yes | | 2 | Yes | | 3 | Yes | | 4 | Yes | | 5 | Yes | | 6 | Yes | | 7 | Yes | | 8 | Yes | | 9 | Yes |
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Announcement
Project announcement
 bug
Something isn't working
 Code Cleanup
Clean up some code
 dependencies
Pull requests that update a dependency file
 Documentation
duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 Low priority
Low priority issue
 Migrations
Migrations
 Models
Model
 question
Further information is requested
 rust
Pull requests that update rust code
 will not work on
No longer to be worked on
 wontfix
This will not be worked on
No Label Code Cleanup Low priority
Milestone
No items
No Milestone Developer Release
Projects
Clear projects
No project
Assignees
Clear assignees
phoenix
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: phoenix/icarus#37
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?