phoenix/icarus
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 33 Wiki Activity

Login HTTP endpoint is insecure #38

New Issue
Closed
opened 2019-05-10 22:06:42 -04:00 by kdeng00 · 0 comments
kdeng00 commented 2019-05-10 22:06:42 -04:00 (Migrated from github.com)
Copy Link
Copy Source

Currently there is not a check done against the database to validate that the user credentials sent with the request to the /api/login HTTP endpoint is valid. Below is a list of ways to secure the login HTTP endpoint:

  • Validate that the user exists in the database and handle the situation accordingly if it does not exist
  • Validate that the password sent with the request matches that which is saved in the database record. The password is encrypted with Bycrypt. Look at the Register API Controller as well as the PasswordEncryption class for how the user is saved to the database
  • Issue an access token only when the user has been successfully validated
Currently there is not a check done against the database to validate that the user credentials sent with the request to the /api/login HTTP endpoint is valid. Below is a list of ways to secure the login HTTP endpoint: * Validate that the user exists in the database and handle the situation accordingly if it does not exist * Validate that the password sent with the request matches that which is saved in the database record. The password is encrypted with [Bycrypt](https://github.com/BcryptNet/bcrypt.net). Look at the [Register](https://github.com/amazing-username/Icarus/blob/master/Controllers/RegisterController.cs) API Controller as well as the [PasswordEncryption](https://github.com/amazing-username/Icarus/blob/master/Controllers/Utilities/PasswordEncryption.cs) class for how the user is saved to the database * Issue an access token only when the user has been successfully validated
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Announcement
Project announcement
 bug
Something isn't working
 Code Cleanup
Clean up some code
 dependencies
Pull requests that update a dependency file
 Documentation
duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 Low priority
Low priority issue
 Migrations
Migrations
 Models
Model
 question
Further information is requested
 rust
Pull requests that update rust code
 will not work on
No longer to be worked on
 wontfix
This will not be worked on
No Label bug
Milestone
No items
No Milestone Developer Release
Projects
Clear projects
No project
Assignees
Clear assignees
phoenix
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: phoenix/icarus#38
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?