phoenix/icarus
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 33 Wiki Activity

Change LastLogin property from User #40

New Issue
Closed
opened 2019-05-10 22:48:09 -04:00 by kdeng00 · 0 comments
kdeng00 commented 2019-05-10 22:48:09 -04:00 (Migrated from github.com)
Copy Link
Copy Source

The User model has a LastLogin Date property that will store the last login date for the user. The issue is when using the Entity Framework Core Migrations that the LastLogin field is required to have a value. This should change to allow null values for the reason that when a user is created they have never logged on before.

This issue can be fixed by looking at the UserContext class and explicitly state that the LastLogin property to allow nulls. This will allow the completion of Issue #28. By default if the user has never logged in then they should be required to verify the credentials that they registered with are valid. This will require an email to be sent to the email address that the user has registered with to verify that the email address has been verified. For now the email address will be the only way of validating the user during the registration phase, eventually phone numbers will be next.

The [User](https://github.com/amazing-username/Icarus/blob/master/Models/User.cs) model has a LastLogin Date property that will store the last login date for the user. The issue is when using the Entity Framework Core Migrations that the LastLogin field is required to have a value. This should change to allow null values for the reason that when a user is created they have never logged on before. This issue can be fixed by looking at the [UserContext](https://github.com/amazing-username/Icarus/blob/master/Models/Context/UserContext.cs) class and explicitly state that the LastLogin property to allow nulls. This will allow the completion of Issue #28. By default if the user has never logged in then they should be required to verify the credentials that they registered with are valid. This will require an email to be sent to the email address that the user has registered with to verify that the email address has been verified. For now the email address will be the only way of validating the user during the registration phase, eventually phone numbers will be next.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Announcement
Project announcement
 bug
Something isn't working
 Code Cleanup
Clean up some code
 dependencies
Pull requests that update a dependency file
 Documentation
duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 Low priority
Low priority issue
 Migrations
Migrations
 Models
Model
 question
Further information is requested
 rust
Pull requests that update rust code
 will not work on
No longer to be worked on
 wontfix
This will not be worked on
No Label bug
Milestone
No items
No Milestone Developer Release
Projects
Clear projects
No project
Assignees
Clear assignees
phoenix
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: phoenix/icarus#40
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?