phoenix/icarus
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 33 Wiki Activity

tsk-203: Addressing hard coding when downloading coverart #223

Merged
kdeng00 merged 5 commits from tsk-203 into main 2025-10-27 14:16:04 -04:00
Conversation 0 Commits 5 Files Changed 3
+14 -3
1 changed files with 14 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 6027d90923 - Show all commits
src/callers/coverart.rs
+14 -3
View File
@@ -179,9 +179,19 @@ pub mod endpoint {
match repo::coverart::get_coverart(&pool, &id).await {
Ok(coverart) => match icarus_models::coverart::io::to_data(&coverart) {
Ok(data) => {
let file_type =
let (file_type, img_type) =
match icarus_meta::detection::coverart::file_type_from_data(&data) {
Ok(file_type) => file_type,
Ok(file_type) => {
if file_type.file_type == icarus_meta::detection::coverart::constants::JPEG_TYPE {
(file_type, icarus_models::types::CoverArtTypes::JpegExtension)
} else if file_type.file_type == icarus_meta::detection::coverart::constants::JPG_TYPE {
(file_type, icarus_models::types::CoverArtTypes::JpgExtension)
} else if file_type.file_type == icarus_meta::detection::coverart::constants::PNG_TYPE {
(file_type, icarus_models::types::CoverArtTypes::PngExtension)
} else {
return (axum::http::StatusCode::INTERNAL_SERVER_ERROR, axum::response::Response::default());
}
}
Err(err) => {
eprintln!("Error: {err:?}");
return (
@@ -193,13 +203,14 @@ pub mod endpoint {
let bytes = axum::body::Bytes::from(data);
let mut response = bytes.into_response();
let headers = response.headers_mut();
let filename = icarus_models::coverart::generate_filename(img_type, true);
headers.insert(
axum::http::header::CONTENT_TYPE,
file_type.mime.parse().unwrap(),
);
headers.insert(
axum::http::header::CONTENT_DISPOSITION,
format!("attachment; filename=\"{}\"", coverart.filename)
format!("attachment; filename=\"{filename}\"")
.parse()
.unwrap(),
);