From 9f9abf4d9fff8d6f34dfdf3753e772c24aab94ba Mon Sep 17 00:00:00 2001 From: kdeng00 Date: Fri, 31 Oct 2025 12:24:55 -0400 Subject: [PATCH 1/3] tsk-201: Making content disposition more unique --- src/callers/queue/coverart.rs | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/src/callers/queue/coverart.rs b/src/callers/queue/coverart.rs index 2ca3748..80bd30d 100644 --- a/src/callers/queue/coverart.rs +++ b/src/callers/queue/coverart.rs @@ -328,9 +328,28 @@ pub mod endpoint { file_type.mime.parse().unwrap(), ); // TODO: Make the conent disposition more dynamic + let coverart_type = if file_type.file_type + == icarus_meta::detection::coverart::constants::JPEG_TYPE + { + icarus_models::types::CoverArtType::JpegExtension + } else if file_type.file_type + == icarus_meta::detection::coverart::constants::JPG_TYPE + { + icarus_models::types::CoverArtType::JpgExtension + } else if file_type.file_type + == icarus_meta::detection::coverart::constants::PNG_TYPE + { + icarus_models::types::CoverArtType::PngExtension + } else { + return ( + axum::http::StatusCode::INTERNAL_SERVER_ERROR, + axum::response::Response::default() + ); + }; + let filename = icarus_models::coverart::generate_filename(coverart_type, true).unwrap(); headers.insert( axum::http::header::CONTENT_DISPOSITION, - format!("attachment; filename=\"{id}.jpg\"") + format!("attachment; filename=\"{filename}\"") .parse() .unwrap(), ); -- 2.47.3 From 877eda891b25ef6591257ada5e778f3b13218714 Mon Sep 17 00:00:00 2001 From: kdeng00 Date: Fri, 31 Oct 2025 12:26:28 -0400 Subject: [PATCH 2/3] tsk-201: Cleanup --- src/callers/queue/coverart.rs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/callers/queue/coverart.rs b/src/callers/queue/coverart.rs index 80bd30d..f333a94 100644 --- a/src/callers/queue/coverart.rs +++ b/src/callers/queue/coverart.rs @@ -327,7 +327,7 @@ pub mod endpoint { axum::http::header::CONTENT_TYPE, file_type.mime.parse().unwrap(), ); - // TODO: Make the conent disposition more dynamic + let coverart_type = if file_type.file_type == icarus_meta::detection::coverart::constants::JPEG_TYPE { @@ -343,10 +343,11 @@ pub mod endpoint { } else { return ( axum::http::StatusCode::INTERNAL_SERVER_ERROR, - axum::response::Response::default() + axum::response::Response::default(), ); }; - let filename = icarus_models::coverart::generate_filename(coverart_type, true).unwrap(); + let filename = + icarus_models::coverart::generate_filename(coverart_type, true).unwrap(); headers.insert( axum::http::header::CONTENT_DISPOSITION, format!("attachment; filename=\"{filename}\"") -- 2.47.3 From 6cf037ed8428a25a951b87e855aaee0abb1cbb4e Mon Sep 17 00:00:00 2001 From: kdeng00 Date: Fri, 31 Oct 2025 12:26:47 -0400 Subject: [PATCH 3/3] tsk-201: Version bump --- Cargo.lock | 2 +- Cargo.toml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 672fd45..e92d082 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -964,7 +964,7 @@ dependencies = [ [[package]] name = "icarus" -version = "0.3.16" +version = "0.3.17" dependencies = [ "axum", "axum-extra", diff --git a/Cargo.toml b/Cargo.toml index 7517d72..b97d6f4 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -1,6 +1,6 @@ [package] name = "icarus" -version = "0.3.16" +version = "0.3.17" edition = "2024" rust-version = "1.90" -- 2.47.3