From 785af4b4a3a35c57f0c335214fd0cf63ab4df459 Mon Sep 17 00:00:00 2001
From: phoenix <kundeng00@pm.me>
Date: Mon, 7 Apr 2025 13:56:26 -0400
Subject: [PATCH] Code cleanup

---
 src/callers/login.rs | 17 +----------------
 src/hashing/mod.rs   | 25 ++++++++-----------------
 2 files changed, 9 insertions(+), 33 deletions(-)

diff --git a/src/callers/login.rs b/src/callers/login.rs
index 6558af6..6f2908e 100644
--- a/src/callers/login.rs
+++ b/src/callers/login.rs
@@ -45,11 +45,7 @@ pub mod endpoint {
         // Check if user exists
         match repo::user::get(&pool, &payload.username).await {
             Ok(user) => {
-                // let salt = repo::salt::get(&pool, &user.salt_id).await.unwrap();
-                // let salt_str = hashing::get_salt(&salt.salt).unwrap();
-                let unhashed_password = payload.password;
-
-                if hashing::verify_password(&unhashed_password, user.password.clone()).unwrap() {
+                if hashing::verify_password(&payload.password, user.password.clone()).unwrap() {
                     // Create token
                     let key = token_stuff::get_key().unwrap();
                     let (token_literal, duration) = token_stuff::create_token(&key).unwrap();
@@ -74,17 +70,6 @@ pub mod endpoint {
                 } else {
                     return not_found("Error Hashing").await;
                 }
-
-                // Check if password is correct
-                /*
-                match hashing::hash_password(&unhashed_password, &salt_str) {
-                    Ok(hash_password) => {
-                    }
-                    Err(err) => {
-                        return not_found(&err.to_string()).await;
-                    }
-                }
-                */
             }
             Err(err) => {
                 return not_found(&err.to_string()).await;
diff --git a/src/hashing/mod.rs b/src/hashing/mod.rs
index 83e7806..2c53f0b 100644
--- a/src/hashing/mod.rs
+++ b/src/hashing/mod.rs
@@ -11,8 +11,7 @@ use argon2::{
 pub fn generate_salt() -> Result<SaltString, argon2::Error> {
     // Generate a random salt
     // SaltString::generate uses OsRng internally for cryptographic security
-    let salt = SaltString::generate(&mut OsRng);
-    Ok(salt)
+    Ok(SaltString::generate(&mut OsRng))
 }
 
 pub fn get_salt(s: &str) -> Result<SaltString, argon2::password_hash::Error> {
@@ -32,9 +31,7 @@ pub fn hash_password(
     // Hash the password with the salt
     // The output is a PasswordHash string format that includes algorithm, version,
     // parameters, salt, and the hash itself.
-    let password_hash = argon2.hash_password(password_bytes, salt)?.to_string();
-
-    Ok(password_hash)
+    Ok(argon2.hash_password(password_bytes, salt)?.to_string())
 }
 
 pub fn verify_password(
@@ -48,11 +45,9 @@ pub fn verify_password(
     let parsed_hash = argon2::PasswordHash::new(stored_hash.as_str())?;
 
     // Create an Argon2 instance (it will use the parameters from the parsed hash)
-    let argon2 = Argon2::default();
-
     // Verify the password against the parsed hash
     // This automatically uses the correct salt and parameters embedded in `parsed_hash`
-    match argon2.verify_password(password_bytes, &parsed_hash) {
+    match Argon2::default().verify_password(password_bytes, &parsed_hash) {
         Ok(()) => Ok(true),                                       // Passwords match
         Err(argon2::password_hash::Error::Password) => Ok(false), // Passwords don't match
         Err(e) => Err(e), // Some other error occurred (e.g., invalid hash format)
@@ -66,8 +61,7 @@ mod tests {
     #[test]
     fn test_hash_password() {
         let some_password = String::from("somethingrandom");
-        let salt = generate_salt().unwrap();
-        match hash_password(&some_password, &salt) {
+        match hash_password(&some_password, &generate_salt().unwrap()) {
             Ok(p) => match verify_password(&some_password, p.clone()) {
                 Ok(res) => {
                     assert_eq!(res, true);
@@ -85,22 +79,19 @@ mod tests {
     #[test]
     fn test_wrong_password() {
         let some_password = String::from("somethingrandom");
-        let salt = generate_salt().unwrap();
-        match hash_password(&some_password, &salt) {
+        match hash_password(&some_password, &generate_salt().unwrap()) {
             Ok(p) => {
                 match verify_password(&some_password, p.clone()) {
                     Ok(res) => {
                         assert_eq!(res, true, "Passwords are not verified");
-                        let wrong_password = String::from("Differentanotherlevel");
-                        // wrong_password = some_password;
-                        // let hashed_wrong_password = hash_password(&wrong_password, &salt).unwrap();
-                        let result = verify_password(&wrong_password, p.clone()).unwrap();
-                        assert_eq!(false, result, "Passwords should not match");
                     }
                     Err(err) => {
                         assert!(false, "Error: {:?}", err.to_string());
                     }
                 }
+                let wrong_password = String::from("Differentanotherlevel");
+                let result = verify_password(&wrong_password, p.clone()).unwrap();
+                assert_eq!(false, result, "Passwords should not match");
             }
             Err(err) => {
                 assert!(false, "Error: {:?}", err.to_string());