Added TODO

.env.docker.sample

@@ -10,4 +10,3 @@ POSTGRES_AUTH_PASSWORD=password
 POSTGRES_AUTH_DB=icarus_auth_db
 POSTGRES_AUTH_HOST=auth_db
 DATABASE_URL=postgresql://${POSTGRES_AUTH_USER}:${POSTGRES_AUTH_PASSWORD}@${POSTGRES_AUTH_HOST}:5432/${POSTGRES_AUTH_DB}
-ENABLE_REGISTRATION=TRUE

.env.sample

@@ -10,4 +10,3 @@ POSTGRES_AUTH_PASSWORD=password
 POSTGRES_AUTH_DB=icarus_auth_test_db
 POSTGRES_AUTH_HOST=localhost
 DATABASE_URL=postgresql://${POSTGRES_AUTH_USER}:${POSTGRES_AUTH_PASSWORD}@${POSTGRES_AUTH_HOST}:5432/${POSTGRES_AUTH_DB}
-ENABLE_REGISTRATION=TRUE

.gitea/workflows/tag_release.yml

@@ -3,21 +3,21 @@ name: Release Tagging
 on:
   push:
     branches:
-      - main
+      - devel
 
 jobs:
   release:
     runs-on: ubuntu-24.04
     steps:
       - name: Checkout code
-        uses: actions/checkout@v5
+        uses: actions/checkout@v3
         with:
           fetch-depth: 0 # Important for git describe --tags
 
       - name: Install Rust
         uses: actions-rs/toolchain@v1
         with:
-          toolchain: 1.90.0
+          toolchain: 1.88.0
           components: cargo
 
       - name: Extract Version from Cargo.toml
@@ -27,10 +27,8 @@ jobs:
           PROJECT_COMMIT_HASH=$(git rev-parse HEAD | cut -c 1-10)
           BRANCH_REF="${GITHUB_REF}"
           BRANCH_NAME=$(echo "$BRANCH_REF" | cut -d '/' -f 3)
-          PROJECT_TAG_RELEASE="v$VERSION-$BRANCH_NAME-$PROJECT_COMMIT_HASH-950"
+          PROJECT_TAG_RELEASE="v$VERSION-$BRANCH_NAME-$PROJECT_COMMIT_HASH"
-
+          echo "::set-output name=project_tag_release::$PROJECT_TAG_RELEASE-950"
-          echo "::set-output name=project_tag_release::$PROJECT_TAG_RELEASE"
-
           echo "Version: $VERSION"
           echo "Hash: $PROJECT_COMMIT_HASH"
           echo "Branch: $BRANCH_NAME"

.gitea/workflows/workflow.yml

@@ -15,10 +15,10 @@ jobs:
     name: Check
     runs-on: ubuntu-24.04
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v4
       - uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.90.0
+          toolchain: 1.88.0
       - run: |
           mkdir -p ~/.ssh
           echo "${{ secrets.MYREPO_TOKEN }}" > ~/.ssh/icarus_models_deploy_key
@@ -50,10 +50,10 @@ jobs:
           --health-retries 5
 
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v4
       - uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.90.0
+          toolchain: 1.88.0
       # --- Add this step for explicit verification ---
       - name: Verify Docker Environment
         run: |
@@ -76,7 +76,6 @@ jobs:
           SECRET_KEY: ${{ secrets.TOKEN_SECRET_KEY }}
           # Make SSH agent available if tests fetch private dependencies
           SSH_AUTH_SOCK: ${{ env.SSH_AUTH_SOCK }}
-          ENABLE_REGISTRATION: 'TRUE'
         run: |
           mkdir -p ~/.ssh
           echo "${{ secrets.MYREPO_TOKEN }}" > ~/.ssh/icarus_models_deploy_key
@@ -92,10 +91,10 @@ jobs:
     name: Rustfmt
     runs-on: ubuntu-24.04
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v4
       - uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.90.0
+          toolchain: 1.88.0
       - run: rustup component add rustfmt
       - run: |
           mkdir -p ~/.ssh
@@ -111,10 +110,10 @@ jobs:
     name: Clippy
     runs-on: ubuntu-24.04
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v4
       - uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.90.0
+          toolchain: 1.88.0
       - run: rustup component add clippy
       - run: |
           mkdir -p ~/.ssh
@@ -130,10 +129,10 @@ jobs:
     name: build
     runs-on: ubuntu-24.04
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v4
       - uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: 1.90.0
+          toolchain: 1.88.0
       - run: |
           mkdir -p ~/.ssh
           echo "${{ secrets.MYREPO_TOKEN }}" > ~/.ssh/icarus_models_deploy_key

Cargo.toml

@@ -1,30 +1,29 @@
 [package]
 name = "icarus_auth"
-version = "0.6.3"
+version = "0.5.0"
 edition = "2024"
-rust-version = "1.90"
+rust-version = "1.88"
 
 [dependencies]
-axum = { version = "0.8.6" }
+axum = { version = "0.8.4" }
-serde = { version = "1.0.228", features = ["derive"] }
+serde = { version = "1.0.219", features = ["derive"] }
-serde_json = { version = "1.0.145" }
+serde_json = { version = "1.0.140" }
-tokio = { version = "1.47.1", features = ["rt-multi-thread"] }
+tokio = { version = "1.45.1", features = ["rt-multi-thread"] }
-tracing-subscriber = { version = "0.3.20" }
+tracing-subscriber = { version = "0.3.19" }
-tower = { version = "0.5.2", features = ["full"] }
+tower = { version = "0.5.2" }
-tower-http = { version = "0.6.6", features = ["cors"] }
+hyper = { version = "1.6.0" }
-hyper = { version = "1.7.0" }
 sqlx = { version = "0.8.6", features = ["postgres", "runtime-tokio-native-tls", "time", "uuid"] }
-uuid = { version = "1.18.1", features = ["v4", "serde"] }
+uuid = { version = "1.17.0", features = ["v4", "serde"] }
 argon2 = { version = "0.5.3", features = ["std"] } # Use the latest 0.5.x version
-rand = { version = "0.9.2" }
+rand = { version = "0.9.1" }
 time = { version = "0.3.41", features = ["macros", "serde"] }
 josekit = { version = "0.10.3" }
 utoipa = { version = "5.4.0", features = ["axum_extras"] }
 utoipa-swagger-ui = { version = "9.0.2", features = ["axum"] }
-icarus_models = { git = "ssh://git@git.kundeng.us/phoenix/icarus_models.git", tag = "v0.8.0" }
+icarus_models = { git = "ssh://git@git.kundeng.us/phoenix/icarus_models.git", tag = "v0.5.6" }
-icarus_envy = { git = "ssh://git@git.kundeng.us/phoenix/icarus_envy.git", tag = "v0.5.0" }
+icarus_envy = { git = "ssh://git@git.kundeng.us/phoenix/icarus_envy.git", tag = "v0.3.5-main-86c5050c7b-006" }
 
 [dev-dependencies]
 http-body-util = { version = "0.1.3" }
-url = { version = "2.5.7" }
+url = { version = "2.5.4" }
 once_cell = { version = "1.21.3" } # Useful for lazy initialization in tests/app setup

Dockerfile

@@ -1,7 +1,7 @@
 # Stage 1: Build the application
 # Use a specific Rust version for reproducibility. Choose one that matches your development environment.
 # Using slim variant for smaller base image
-FROM rust:1.90 as builder
+FROM rust:1.88 as builder
 
 # Set the working directory inside the container
 WORKDIR /usr/src/app

README.md

@@ -8,26 +8,22 @@ need to be modified. The `SECRET_KEY` variable should be changed since it will b
 generation. The `SECRET_PASSPHASE` should also be changed when in production mode, but make sure
 the respective `passphrase` database table record exists.
 
-To enable or disable registrations, use `TRUE` or `FALSE` for the `ENABLE_REGISTRATION` variable.
+Build image
-By default it is `TRUE`.
-
-
-### Build image
 ```
 docker compose build
 ```
 
-### Start images
+Start images
 ```
 docker compose up -d --force-recreate
 ```
 
-### Bring it down
+Bring it down
 ```
 docker compose down -v
 ```
 
-### Pruning
+Pruning
 ```
 docker system prune -a
 ```

docker-compose.yaml

@@ -9,7 +9,7 @@ services:
     container_name: icarus_auth # Optional: Give the container a specific name
     ports:
       # Map host port 8000 to container port 3000 (adjust as needed)
-      - "8001:8001"
+      - "8000:3000"
     env_file:
       - .env
     depends_on:

src/callers/login.rs

@@ -96,7 +96,7 @@ pub mod endpoint {
             Ok(user) => {
                 if hashing::verify_password(&payload.password, user.password.clone()).unwrap() {
                     // Create token
-                    let key = icarus_envy::environment::get_secret_key().await.value;
+                    let key = icarus_envy::environment::get_secret_key().await;
                     let (token_literal, duration) =
                         token_stuff::create_token(&key, &user.id).unwrap();
 
@@ -155,7 +155,7 @@ pub mod endpoint {
 
         match repo::service::valid_passphrase(&pool, &payload.passphrase).await {
             Ok((id, _passphrase, _date_created)) => {
-                let key = icarus_envy::environment::get_secret_key().await.value;
+                let key = icarus_envy::environment::get_secret_key().await;
                 let (token_literal, duration) =
                     token_stuff::create_service_token(&key, &id).unwrap();
 
@@ -207,7 +207,7 @@ pub mod endpoint {
         axum::Json<response::refresh_token::Response>,
     ) {
         let mut response = response::refresh_token::Response::default();
-        let key = icarus_envy::environment::get_secret_key().await.value;
+        let key = icarus_envy::environment::get_secret_key().await;
 
         if token_stuff::verify_token(&key, &payload.access_token) {
             let token_type = token_stuff::get_token_type(&key, &payload.access_token).unwrap();

src/callers/register.rs

@@ -52,108 +52,69 @@ pub async fn register_user(
     axum::Extension(pool): axum::Extension<sqlx::PgPool>,
     Json(payload): Json<request::Request>,
 ) -> (StatusCode, Json<response::Response>) {
-    let registration_enabled = match is_registration_enabled().await {
+    let mut user = icarus_models::user::User {
-        Ok(value) => value,
+        id: uuid::Uuid::nil(),
-        Err(err) => {
+        username: payload.username.clone(),
-            eprintln!("Error: {err:?}");
+        password: payload.password.clone(),
-            return (
+        email: payload.email.clone(),
-                axum::http::StatusCode::INTERNAL_SERVER_ERROR,
+        phone: payload.phone.clone(),
-                Json(response::Response {
+        firstname: payload.firstname.clone(),
-                    message: String::from("Registration check failed"),
+        lastname: payload.lastname.clone(),
-                    data: Vec::new(),
+        status: String::from("Active"),
-                }),
+        email_verified: true,
-            );
+        date_created: Some(time::OffsetDateTime::now_utc()),
-        }
+        last_login: None,
+        salt_id: uuid::Uuid::nil(),
     };
 
-    if registration_enabled {
+    match repo::user::exists(&pool, &user.username).await {
-        let mut user = icarus_models::user::User {
+        Ok(res) => {
-            username: payload.username.clone(),
+            if res {
-            password: payload.password.clone(),
+                (
-            email: payload.email.clone(),
+                    StatusCode::NOT_FOUND,
-            phone: payload.phone.clone(),
+                    Json(response::Response {
-            firstname: payload.firstname.clone(),
+                        message: String::from("Error"),
-            lastname: payload.lastname.clone(),
+                        data: vec![user],
-            status: String::from("Active"),
+                    }),
-            email_verified: true,
+                )
-            ..Default::default()
+            } else {
-        };
+                let salt_string = hashing::generate_salt().unwrap();
+                let mut salt = icarus_models::user::salt::Salt::default();
+                let generated_salt = salt_string;
+                salt.salt = generated_salt.to_string();
+                salt.id = repo::salt::insert(&pool, &salt).await.unwrap();
+                user.salt_id = salt.id;
+                let hashed_password =
+                    hashing::hash_password(&user.password, &generated_salt).unwrap();
+                user.password = hashed_password;
 
-        match repo::user::exists(&pool, &user.username).await {
+                match repo::user::insert(&pool, &user).await {
-            Ok(res) => {
+                    Ok(id) => {
-                if res {
+                        user.id = id;
-                    (
+                        (
-                        StatusCode::BAD_REQUEST,
+                            StatusCode::CREATED,
-                        Json(response::Response {
-                            message: String::from("Error"),
-                            data: Vec::new(),
-                        }),
-                    )
-                } else {
-                    let salt_string = hashing::generate_salt().unwrap();
-                    let mut salt = icarus_models::user::salt::Salt::default();
-                    let generated_salt = salt_string;
-                    salt.salt = generated_salt.to_string();
-                    salt.id = repo::salt::insert(&pool, &salt).await.unwrap();
-                    user.salt_id = salt.id;
-                    let hashed_password =
-                        hashing::hash_password(&user.password, &generated_salt).unwrap();
-                    user.password = hashed_password;
-
-                    match repo::user::insert(&pool, &user).await {
-                        Ok((id, date_created)) => {
-                            user.id = id;
-                            user.date_created = date_created;
-                            (
-                                StatusCode::CREATED,
-                                Json(response::Response {
-                                    message: String::from("User created"),
-                                    data: vec![user],
-                                }),
-                            )
-                        }
-                        Err(err) => (
-                            StatusCode::BAD_REQUEST,
                             Json(response::Response {
-                                message: err.to_string(),
+                                message: String::from("User created"),
                                 data: vec![user],
                             }),
-                        ),
+                        )
                     }
+                    Err(err) => (
+                        StatusCode::BAD_REQUEST,
+                        Json(response::Response {
+                            message: err.to_string(),
+                            data: vec![user],
+                        }),
+                    ),
                 }
             }
-            Err(err) => (
-                StatusCode::BAD_REQUEST,
-                Json(response::Response {
-                    message: err.to_string(),
-                    data: vec![user],
-                }),
-            ),
         }
-    } else {
+        Err(err) => (
-        (
+            StatusCode::BAD_REQUEST,
-            axum::http::StatusCode::NOT_ACCEPTABLE,
             Json(response::Response {
-                message: String::from("Registration is not enabled"),
+                message: err.to_string(),
-                data: Vec::new(),
+                data: vec![user],
             }),
-        )
+        ),
-    }
-}
-
-/// Checks to see if registration is enabled
-async fn is_registration_enabled() -> Result<bool, std::io::Error> {
-    let key = String::from("ENABLE_REGISTRATION");
-    let var = icarus_envy::environment::get_env(&key).await;
-    let parsed_value = var.value.to_uppercase();
-
-    if parsed_value == "TRUE" {
-        Ok(true)
-    } else if parsed_value == "FALSE" {
-        Ok(false)
-    } else {
-        Err(std::io::Error::other(
-            "Could not determine value of ENABLE_REGISTRATION",
-        ))
     }
 }

src/config/mod.rs

@@ -6,5 +6,5 @@ fn get_address() -> String {
 }
 
 fn get_port() -> String {
-    String::from("8001")
+    String::from("3000")
 }

src/lib.rs

@@ -16,7 +16,7 @@ pub mod db {
     use crate::connection_settings;
 
     pub async fn create_pool() -> Result<sqlx::PgPool, sqlx::Error> {
-        let database_url = icarus_envy::environment::get_db_url().await.value;
+        let database_url = icarus_envy::environment::get_db_url().await;
         println!("Database url: {database_url}");
 
         PgPoolOptions::new()

src/main.rs

@@ -8,7 +8,7 @@ async fn main() {
 
     let app = init::app().await;
 
-    // run our app with hyper, listening globally on port 8001
+    // run our app with hyper, listening globally on port 3000
     let url = config::get_full();
     let listener = tokio::net::TcpListener::bind(url).await.unwrap();
     axum::serve(listener, app).await.unwrap();
@@ -45,54 +45,6 @@ mod init {
     )]
     struct ApiDoc;
 
-    mod cors {
-        pub async fn configure_cors() -> tower_http::cors::CorsLayer {
-            // Start building the CORS layer with common settings
-            let cors = tower_http::cors::CorsLayer::new()
-                .allow_methods([
-                    axum::http::Method::GET,
-                    axum::http::Method::POST,
-                    axum::http::Method::PUT,
-                    axum::http::Method::DELETE,
-                ]) // Specify allowed methods:cite[2]
-                .allow_headers([
-                    axum::http::header::CONTENT_TYPE,
-                    axum::http::header::AUTHORIZATION,
-                ]) // Specify allowed headers:cite[2]
-                .allow_credentials(true) // If you need to send cookies or authentication headers:cite[2]
-                .max_age(std::time::Duration::from_secs(3600)); // Cache the preflight response for 1 hour:cite[2]
-
-            // Dynamically set the allowed origin based on the environment
-            match std::env::var(icarus_envy::keys::APP_ENV).as_deref() {
-                Ok("production") => {
-                    let allowed_origins_env = icarus_envy::environment::get_allowed_origins().await;
-                    match icarus_envy::utility::delimitize(&allowed_origins_env) {
-                        Ok(alwd) => {
-                            let allowed_origins: Vec<axum::http::HeaderValue> = alwd
-                                .into_iter()
-                                .map(|s| s.parse::<axum::http::HeaderValue>().unwrap())
-                                .collect();
-                            cors.allow_origin(allowed_origins)
-                        }
-                        Err(err) => {
-                            eprintln!(
-                                "Could not parse out allowed origins from env: Error: {err:?}"
-                            );
-                            std::process::exit(-1);
-                        }
-                    }
-                }
-                _ => {
-                    // Development (default): Allow localhost origins
-                    cors.allow_origin(vec![
-                        "http://localhost:4200".parse().unwrap(),
-                        "http://127.0.0.1:4200".parse().unwrap(),
-                    ])
-                }
-            }
-        }
-    }
-
     pub async fn routes() -> Router {
         // build our application with a route
         Router::new()
@@ -120,7 +72,6 @@ mod init {
                 callers::endpoints::REFRESH_TOKEN,
                 post(callers::login::endpoint::refresh_token),
             )
-            .layer(cors::configure_cors().await)
     }
 
     pub async fn app() -> Router {
@@ -158,7 +109,7 @@ mod tests {
         pub const LIMIT: usize = 6;
 
         pub async fn get_pool() -> Result<sqlx::PgPool, sqlx::Error> {
-            let tm_db_url = icarus_envy::environment::get_db_url().await.value;
+            let tm_db_url = icarus_envy::environment::get_db_url().await;
             let tm_options = sqlx::postgres::PgConnectOptions::from_str(&tm_db_url).unwrap();
             sqlx::PgPool::connect_with(tm_options).await
         }
@@ -171,7 +122,7 @@ mod tests {
         }
 
         pub async fn connect_to_db(db_name: &str) -> Result<sqlx::PgPool, sqlx::Error> {
-            let db_url = icarus_envy::environment::get_db_url().await.value;
+            let db_url = icarus_envy::environment::get_db_url().await;
             let options = sqlx::postgres::PgConnectOptions::from_str(&db_url)?.database(db_name);
             sqlx::PgPool::connect_with(options).await
         }
@@ -198,7 +149,7 @@ mod tests {
         }
 
         pub async fn get_database_name() -> Result<String, Box<dyn std::error::Error>> {
-            let database_url = icarus_envy::environment::get_db_url().await.value;
+            let database_url = icarus_envy::environment::get_db_url().await;
 
             let parsed_url = url::Url::parse(&database_url)?;
             if parsed_url.scheme() == "postgres" || parsed_url.scheme() == "postgresql" {
@@ -501,7 +452,7 @@ mod tests {
 
         let app = init::routes().await.layer(axum::Extension(pool));
         let id = uuid::Uuid::parse_str("22f9c775-cce9-457a-a147-9dafbb801f61").unwrap();
-        let key = icarus_envy::environment::get_secret_key().await.value;
+        let key = icarus_envy::environment::get_secret_key().await;
 
         match icarus_auth::token_stuff::create_service_token(&key, &id) {
             Ok((token, _expire)) => {

src/repo/mod.rs

@@ -94,7 +94,7 @@ pub mod user {
     pub async fn insert(
         pool: &sqlx::PgPool,
         user: &icarus_models::user::User,
-    ) -> Result<(uuid::Uuid, std::option::Option<time::OffsetDateTime>), sqlx::Error> {
+    ) -> Result<uuid::Uuid, sqlx::Error> {
         let row = sqlx::query(
             r#"
                 INSERT INTO "user" (username, password, email, phone, firstname, lastname, email_verified, status, salt_id) 
@@ -124,10 +124,10 @@ pub mod user {
                 .map_err(|_e| sqlx::Error::RowNotFound)?,
         };
 
-        if result.id.is_nil() && result.date_created.is_none() {
+        if !result.id.is_nil() {
-            Err(sqlx::Error::RowNotFound)
+            Ok(result.id)
         } else {
-            Ok((result.id, result.date_created))
+            Err(sqlx::Error::RowNotFound)
         }
     }
 }

src/token_stuff/mod.rs

@@ -124,9 +124,7 @@ mod tests {
     #[test]
     fn test_tokenize() {
         let rt = tokio::runtime::Runtime::new().unwrap();
-        let special_key = rt
+        let special_key = rt.block_on(icarus_envy::environment::get_secret_key());
-            .block_on(icarus_envy::environment::get_secret_key())
-            .value;
         let id = uuid::Uuid::new_v4();
         match create_token(&special_key, &id) {
             Ok((token, _duration)) => {