From 6760aa1ab8013639fa96c0a3fbf3573ce0357251 Mon Sep 17 00:00:00 2001 From: kdeng00 Date: Fri, 24 Oct 2025 20:31:29 -0400 Subject: [PATCH] tsk-82: Refactored validate_flags() method --- src/managers/action_managers.rs | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/src/managers/action_managers.rs b/src/managers/action_managers.rs index 6de2411..1a656fa 100644 --- a/src/managers/action_managers.rs +++ b/src/managers/action_managers.rs @@ -66,19 +66,18 @@ impl ActionManager { let mut i = 0; - while i < flag_vals.len() { - let flag = &flag_vals[i]; - + for flag in &flag_vals { let mut flg = models::flags::Flags::default(); - // TODO: Refactor this if self.is_valid_flag(flag) && self.does_flag_have_value(flag) { - flg.flag = String::from(flag); - flg.value = String::from(&flag_vals[i + 1]); + if self.does_flag_have_value(flag) { + flg.flag = String::from(flag); + flg.value = String::from(&flag_vals[i + 1]); - i += 1; - } else if self.is_valid_flag(flag) { - flg.flag = String::from(flag); + i += 1; + } else { + flg.flag = String::from(flag); + } } else { utilities::checks::exit_program(-1); }