Workflow change (#15)

Reviewed-on: phoenix/icarus-models#15
Co-authored-by: phoenix <kundeng94@gmail.com>
Co-committed-by: phoenix <kundeng94@gmail.com>

.gitea/workflows/tag_release.yaml

@@ -0,0 +1,57 @@
+name: Release Tagging
+
+on:
+  push:
+    branches:
+      - main
+      - devel
+    tags:
+      - 'v*' # Trigger on tags matching v*
+
+jobs:
+  release:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v3
+        with:
+          fetch-depth: 0 # Important for git describe --tags
+
+      - name: Install Rust
+        uses: actions-rs/toolchain@v1
+        with:
+          toolchain: 1.85.0
+          components: cargo
+
+      - name: Extract Version from Cargo.toml
+        id: version
+        run: |
+          VERSION=$(grep '^version = "' Cargo.toml | sed -E 's/version = "([^"]+)"/\1/')
+          PROJECT_COMMIT_HASH=$(git rev-parse HEAD | cut -c 1-10)
+          BRANCH_REF="${GITHUB_REF}"
+          BRANCH_NAME=$(echo "$BRANCH_REF" | cut -d '/' -f 3)
+          PROJECT_TAG_RELEASE="v$VERSION-$BRANCH_NAME-$PROJECT_COMMIT_HASH"
+          echo "::set-output name=project_tag_release::$PROJECT_TAG_RELEASE-111"
+          echo "Version: $VERSION"
+          echo "Hash: $PROJECT_COMMIT_HASH"
+          echo "Branch: $BRANCH_NAME"
+          echo "Tag Release: $PROJECT_TAG_RELEASE"
+
+      - name: Print version
+        id: Version
+        run: |
+          echo "Printing version"
+          echo "Version: ${{ steps.version.outputs.project_tag_release }}"
+
+      - name: Create GitHub Release
+        uses: actions/create-release@v1
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          tag_name: ${{ steps.version.outputs.project_tag_release }}
+          release_name: Release ${{ steps.version.outputs.project_tag_release }}
+          body: |
+           Release of version ${{ steps.version.outputs.project_tag_release }}
+          # draft: false
+          # prerelease: ${{ startsWith(github.ref, 'v') == false }} # prerelease if not a valid release tag
+

.gitea/workflows/workflow.yaml

@@ -0,0 +1,66 @@
+name: Rust Build
+
+on:
+  push:
+    branches:
+      - main 
+      - devel
+  pull_request:
+    branches:
+      - main 
+      - devel
+
+jobs:
+  check:
+    name: Check
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions-rust-lang/setup-rust-toolchain@v1
+        with:
+          toolchain: 1.85.0
+      - run: cargo check
+
+  test:
+    name: Test Suite
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions-rust-lang/setup-rust-toolchain@v1
+        with:
+          toolchain: 1.85.0
+      - run: cargo test
+
+  fmt:
+    name: Rustfmt
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions-rust-lang/setup-rust-toolchain@v1
+        with:
+          toolchain: 1.85.0
+      - run: rustup component add rustfmt
+      - run: cargo fmt --all -- --check
+
+  clippy:
+    name: Clippy
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions-rust-lang/setup-rust-toolchain@v1
+        with:
+          toolchain: 1.85.0
+      - run: rustup component add clippy
+      - run: cargo clippy -- -D warnings
+
+  build:
+    name: build
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions-rust-lang/setup-rust-toolchain@v1
+        with:
+          toolchain: 1.85.0
+      - run: cargo build
+
+

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "icarus-models"
-version = "0.1.10"
+version = "0.1.14"
 edition = "2024"
 description = "models used for the icarus project"
 license = "MIT"

src/access_level.rs

@@ -20,23 +20,23 @@ impl Default for AccessLevel {
 }
 
 pub fn default_level() -> AccessLevel {
-    return AccessLevel {
+    AccessLevel {
         id: -1,
         level: String::from("Public"),
         song_id: -1,
-    };
+    }
 }
 
 pub fn private_level() -> AccessLevel {
-    return AccessLevel {
+    AccessLevel {
         id: -1,
         level: String::from("Private"),
         song_id: -1,
-    };
+    }
 }
 
 impl AccessLevel {
     pub fn _to_json(&self) -> Result<String, serde_json::Error> {
-        return serde_json::to_string_pretty(&self);
+        serde_json::to_string_pretty(&self)
     }
 }

src/coverart.rs

@@ -16,12 +16,8 @@ impl CoverArt {
         let mut file = std::fs::File::open(path)?;
         let mut buffer = Vec::new();
         match file.read_to_end(&mut buffer) {
-            Ok(_) => {
+            Ok(_) => Ok(buffer),
-                return Ok(buffer);
+            Err(err) => Err(err),
-            }
-            Err(err) => {
-                return Err(err);
-            }
         }
     }
 }

src/login_result.rs

@@ -26,6 +26,6 @@ impl Default for LoginResult {
 
 impl LoginResult {
     pub fn _to_json(&self) -> Result<String, serde_json::Error> {
-        return serde_json::to_string_pretty(&self);
+        serde_json::to_string_pretty(&self)
     }
 }

src/song.rs

@@ -1,4 +1,4 @@
-use std::default::Default;
+// use std::default::Default;
 use std::io::Read;
 
 use crate::constants;
@@ -64,6 +64,7 @@ fn is_dur_not_set(num: &i32) -> bool {
     *num == 0
 }
 
+/*
 impl Default for Song {
     fn default() -> Self {
         Song {
@@ -92,13 +93,14 @@ impl Default for Song {
         }
     }
 }
+*/
 
 impl Song {
     pub fn to_metadata_json(&self, pretty: bool) -> Result<String, serde_json::Error> {
         if pretty {
-            return serde_json::to_string_pretty(&self);
+            serde_json::to_string_pretty(&self)
         } else {
-            return serde_json::to_string(&self);
+            serde_json::to_string(&self)
         }
     }
 
@@ -111,7 +113,7 @@ impl Song {
         }
 
         let directory = &self.directory;
-        let mut buffer: String = String::from(directory.clone());
+        let mut buffer: String = directory.clone();
         let last_index = directory.len() - 1;
 
         if let Some(character) = directory.chars().nth(last_index) {
@@ -121,12 +123,12 @@ impl Song {
 
             buffer += &self.filename.clone();
 
-            return Ok(buffer);
+            Ok(buffer)
         } else {
-            return Err(std::io::Error::new(
+            Err(std::io::Error::new(
                 std::io::ErrorKind::Other,
                 "Could not access last character of directory",
-            ));
+            ))
         }
     }
 
@@ -139,50 +141,45 @@ impl Song {
                 let mut buffer: Vec<u8> = Vec::new();
                 file.read_to_end(&mut buffer)?;
 
-                if buffer.len() == 0 {
+                if buffer.is_empty() {
-                    return Err(std::io::Error::new(
+                    Err(std::io::Error::new(
                         std::io::ErrorKind::Other,
                         "File is empty",
-                    ));
+                    ))
                 } else {
-                    return Ok(buffer);
+                    Ok(buffer)
                 }
             }
-            Err(er) => {
+            Err(er) => Err(er),
-                return Err(er);
-            }
         }
     }
 
-    pub fn generate_filename(&self, typ: types::types::Types, randomize: bool) -> String {
+    pub fn generate_filename(&self, typ: types::MusicTypes, randomize: bool) -> String {
         let mut filename: String = String::new();
         let filename_len = 10;
 
         let file_extension = match typ {
-            types::types::Types::DefaultMusicExtension => {
+            types::MusicTypes::DefaultMusicExtension => {
                 String::from(constants::DEFAULTMUSICEXTENSION)
             }
 
-            types::types::Types::WavExtension => String::from(constants::WAVEXTENSION),
+            types::MusicTypes::WavExtension => String::from(constants::WAVEXTENSION),
-            types::types::Types::FlacExtension => String::from(constants::FLACEXTENSION),
+            types::MusicTypes::FlacExtension => String::from(constants::FLACEXTENSION),
-            types::types::Types::MPThreeExtension => String::from(constants::MPTHREEEXTENSION),
+            types::MusicTypes::MPThreeExtension => String::from(constants::MPTHREEEXTENSION),
         };
 
         if randomize {
             let some_chars: String = String::from("abcdefghij0123456789");
-            let mut rng = rand::thread_rng();
+            let mut rng = rand::rng();
 
             for _i in 0..filename_len {
-                let random_number: i32 = rng.gen_range(0..=19);
+                let random_number: i32 = rng.random_range(0..=19);
                 let index = random_number as usize;
                 let rando_char = some_chars.chars().nth(index);
 
-                match rando_char {
+                if let Some(c) = rando_char {
-                    Some(c) => {
+                    filename.push(c);
-                        filename.push(c);
+                }
-                    }
-                    None => {}
-                };
             }
         } else {
             filename += "track-output";
@@ -190,10 +187,11 @@ impl Song {
 
         filename += &file_extension;
 
-        return filename;
+        filename
     }
 }
 
+/*
 mod embedded {
     use std::io::Read;
 
@@ -202,9 +200,9 @@ mod embedded {
     impl Song {
         pub fn to_metadata_json(&self, pretty: bool) -> Result<String, serde_json::Error> {
             if pretty {
-                return serde_json::to_string_pretty(&self);
+                serde_json::to_string_pretty(&self)
             } else {
-                return serde_json::to_string(&self);
+                serde_json::to_string(&self)
             }
         }
 
@@ -217,7 +215,7 @@ mod embedded {
             }
 
             let directory = &self.directory;
-            let mut buffer: String = String::from(directory.clone());
+            let mut buffer: String = directory.clone();
             let last_index = directory.len() - 1;
 
             if let Some(character) = directory.chars().nth(last_index) {
@@ -227,12 +225,12 @@ mod embedded {
 
                 buffer += &self.filename.clone();
 
-                return Ok(buffer);
+                Ok(buffer)
             } else {
-                return Err(std::io::Error::new(
+                Err(std::io::Error::new(
                     std::io::ErrorKind::Other,
                     "Could not access last character of directory",
-                ));
+                ))
             }
         }
 
@@ -245,18 +243,16 @@ mod embedded {
                     let mut buffer: Vec<u8> = Vec::new();
                     file.read_to_end(&mut buffer)?;
 
-                    if buffer.len() == 0 {
+                    if buffer.is_empty() {
-                        return Err(std::io::Error::new(
+                        Err(std::io::Error::new(
                             std::io::ErrorKind::Other,
                             "File is empty",
-                        ));
+                        ))
                     } else {
-                        return Ok(buffer);
+                        Ok(buffer)
                     }
                 }
-                Err(er) => {
+                Err(er) => Err(er),
-                    return Err(er);
-                }
             }
         }
     }
@@ -348,3 +344,4 @@ mod embedded {
         }
     }
 }
+*/

src/token.rs

@@ -43,18 +43,18 @@ impl AccessToken {
     pub fn bearer_token(&self) -> String {
         let mut token: String = String::from("Bearer ");
         token += &self.token.clone();
-        return token;
+        token
     }
 }
 
 impl Token {
     pub fn _to_json(&self) -> Result<String, serde_json::Error> {
-        return serde_json::to_string_pretty(&self);
+        serde_json::to_string_pretty(&self)
     }
 
     // TODO: Implement
     pub fn token_expired(&self) -> bool {
-        return false;
+        false
     }
 
     // TODO: Implement
@@ -65,6 +65,6 @@ impl Token {
             return true;
         }
 
-        return false;
+        false
     }
 }

src/types.rs

@@ -1,8 +1,6 @@
-pub mod types {
+pub enum MusicTypes {
-    pub enum Types {
+    DefaultMusicExtension,
-        DefaultMusicExtension,
+    WavExtension,
-        WavExtension,
+    FlacExtension,
-        FlacExtension,
+    MPThreeExtension,
-        MPThreeExtension,
-    }
 }

src/user.rs

@@ -52,9 +52,9 @@ impl Default for User {
 impl User {
     pub fn to_json(&self, output_pretty: bool) -> Result<String, serde_json::Error> {
         if output_pretty {
-            return serde_json::to_string_pretty(&self);
+            serde_json::to_string_pretty(&self)
         } else {
-            return serde_json::to_string(&self);
+            serde_json::to_string(&self)
         }
     }
 }