Code cleanup

Cargo.lock

@@ -142,7 +142,7 @@ checksum = "5971ac85611da7067dbfcabef3c70ebb5606018acd9e2a3903a0da507521e0d5"
 
 [[package]]
 name = "icarus_models"
-version = "0.6.3"
+version = "0.6.0"
 dependencies = [
  "josekit",
  "rand",

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "icarus_models"
-version = "0.6.3"
+version = "0.6.0"
 edition = "2024"
 rust-version = "1.88"
 description = "models used for the icarus project"

src/song.rs

@@ -7,9 +7,6 @@ use crate::constants;
 use crate::init;
 use crate::types;
 
-/// Length of characters of a filename to be generated
-const FILENAME_LENGTH: i32 = 16;
-
 #[derive(Clone, Debug, Default, Deserialize, Serialize, utoipa::ToSchema)]
 pub struct Song {
     #[serde(skip_serializing_if = "init::is_uuid_nil")]
@@ -93,42 +90,11 @@ impl Song {
         }
     }
 
-    /// Saves the song to the filesystem using the song's data
+    // TODO: Make this available as a function
-    pub fn save_to_filesystem(&self) -> Result<(), std::io::Error> {
+    pub fn generate_filename(&self, typ: types::MusicTypes, randomize: bool) -> String {
-        match self.song_path() {
+        let mut filename: String = String::new();
-            Ok(song_path) => match std::fs::File::create(&song_path) {
+        let filename_len = 10;
-                Ok(mut file) => match file.write_all(&self.data) {
-                    Ok(_res) => Ok(()),
-                    Err(err) => Err(err),
-                },
-                Err(err) => Err(err),
-            },
-            Err(err) => Err(err),
-        }
-    }
 
-    /// Removes the song from the filesystem
-    pub fn remove_from_filesystem(&self) -> Result<(), std::io::Error> {
-        match self.song_path() {
-            Ok(song_path) => {
-                let p = std::path::Path::new(&song_path);
-                if p.exists() {
-                    match std::fs::remove_file(&p) {
-                        Ok(_) => Ok(()),
-                        Err(err) => Err(err),
-                    }
-                } else {
-                    Ok(())
-                }
-            }
-            Err(err) => Err(err),
-        }
-    }
-}
-
-/// Generates a filename. In order to save a song to the filesystem, the song must have
-/// a directory and filename
-pub fn generate_filename(typ: types::MusicTypes, randomize: bool) -> String {
         let file_extension = match typ {
             types::MusicTypes::DefaultMusicExtension => {
                 String::from(constants::file_extensions::audio::DEFAULTMUSICEXTENSION)
@@ -146,22 +112,42 @@ pub fn generate_filename(typ: types::MusicTypes, randomize: bool) -> String {
         };
 
         if randomize {
-        let mut filename: String = String::new();
             let some_chars: String = String::from("abcdefghij0123456789");
             let mut rng = rand::rng();
 
-        for _ in 0..FILENAME_LENGTH {
+            for _i in 0..filename_len {
-            let index = rng.random_range(0..=19);
+                let random_number: i32 = rng.random_range(0..=19);
+                let index = random_number as usize;
                 let rando_char = some_chars.chars().nth(index);
 
                 if let Some(c) = rando_char {
                     filename.push(c);
                 }
             }
-        filename + &file_extension
         } else {
-        "track-output".to_string() + &file_extension
+            filename += "track-output";
         }
+
+        filename += &file_extension;
+
+        filename
+    }
+
+    /// Saves the song to the filesystem using the song's data
+    pub fn save_to_filesystem(&self) -> Result<(), std::io::Error> {
+        match self.song_path() {
+            Ok(song_path) => match std::fs::File::create(&song_path) {
+                Ok(mut file) => match file.write_all(&self.data) {
+                    Ok(_res) => Ok(()),
+                    Err(err) => Err(err),
+                },
+                Err(err) => Err(err),
+            },
+            Err(err) => Err(err),
+        }
+    }
+
+    // TODO: Add function to remove file from the filesystem
 }
 
 /// I/O operations for songs

tests/tests.rs

@@ -107,7 +107,7 @@ mod song_tests {
         };
 
         assert_eq!(song.directory.is_empty(), false);
-        song_cpy.filename = song::generate_filename(types::MusicTypes::FlacExtension, true);
+        song_cpy.filename = song.generate_filename(types::MusicTypes::FlacExtension, true);
         println!("Directory: {:?}", song_cpy.directory);
         println!("File to be created: {:?}", song_cpy.filename);
 
@@ -120,7 +120,7 @@ mod song_tests {
     }
 
     #[test]
-    fn test_save_song_to_filesystem_and_remove() {
+    fn test_save_song_to_filesystem() {
         let mut song = song::Song::default();
         song.directory = utils::get_tests_directory();
         song.filename = String::from("track02.flac");
@@ -132,21 +132,17 @@ mod song_tests {
         };
 
         match song::io::copy_song(&song, &mut copied_song) {
-            Ok(_) => match copied_song.remove_from_filesystem() {
             Ok(_) => {}
             Err(err) => {
                 assert!(false, "Error: {err:?}")
             }
-            },
-            Err(err) => {
-                assert!(false, "Error: {err:?}")
-            }
         }
     }
 }
 
 #[cfg(test)]
 mod album_tests {
+
     use crate::utils;
     use icarus_models::album;