tsk-72: Test fix

Cargo.lock

@@ -149,7 +149,7 @@ checksum = "5419bdc4f6a9207fbeba6d11b604d481addf78ecd10c11ad51e76c2f6482748d"
 
 [[package]]
 name = "icarus_models"
-version = "0.7.0"
+version = "0.7.1"
 dependencies = [
  "josekit",
  "rand",

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "icarus_models"
-version = "0.7.0"
+version = "0.7.1"
 edition = "2024"
 rust-version = "1.90"
 description = "models used for the icarus project"

src/coverart.rs

@@ -10,22 +10,18 @@ pub struct CoverArt {
     pub directory: String,
     pub filename: String,
     #[serde(skip)]
-    pub path: String,
-    #[serde(skip)]
     pub data: Vec<u8>,
     pub song_id: uuid::Uuid,
 }
 
 pub mod init {
-    use crate::coverart::CoverArt;
+    use super::CoverArt;
 
-    pub fn init_coverart_only_path(path: String) -> CoverArt {
+    /// Initializes the CoverArt with just the directory and filename
+    pub fn init_coverart_dir_and_filename(directory: &str, filename: &str) -> CoverArt {
         CoverArt {
-            id: uuid::Uuid::nil(),
-            title: String::new(),
-            path: path.clone(),
-            data: Vec::new(),
-            song_id: uuid::Uuid::nil(),
+            directory: String::from(directory),
+            filename: String::from(filename),
             ..Default::default()
         }
     }
@@ -34,18 +30,23 @@ pub mod init {
 impl CoverArt {
     /// Saves the coverart to the filesystem
     pub fn save_to_filesystem(&self) -> Result<(), std::io::Error> {
-        match std::fs::File::create(&self.path) {
+        match self.get_path() {
+            Ok(path) => match std::fs::File::create(&path) {
                 Ok(mut file) => match file.write_all(&self.data) {
                     Ok(_) => Ok(()),
                     Err(err) => Err(err),
                 },
                 Err(err) => Err(err),
+            },
+            Err(err) => Err(err),
         }
     }
 
     /// Removes the coverart from the filesystem
     pub fn remove_from_filesystem(&self) -> Result<(), std::io::Error> {
-        let p = std::path::Path::new(&self.path);
+        match self.get_path() {
+            Ok(path) => {
+                let p = std::path::Path::new(&path);
                 if p.exists() {
                     match std::fs::remove_file(p) {
                         Ok(_) => Ok(()),
@@ -57,6 +58,9 @@ impl CoverArt {
                     ))
                 }
             }
+            Err(err) => Err(err),
+        }
+    }
 
     /// Gets the path of the CoverArt
     pub fn get_path(&self) -> Result<String, std::io::Error> {
@@ -90,7 +94,8 @@ pub mod io {
 
     /// Gets the raw data of the cover art
     pub fn to_data(coverart: &super::CoverArt) -> Result<Vec<u8>, std::io::Error> {
-        let path: &String = &coverart.path;
+        match coverart.get_path() {
+            Ok(path) => {
                 let mut file = std::fs::File::open(path)?;
                 let mut buffer = Vec::new();
                 match file.read_to_end(&mut buffer) {
@@ -98,6 +103,9 @@ pub mod io {
                     Err(err) => Err(err),
                 }
             }
+            Err(err) => Err(err),
+        }
+    }
 }
 
 #[cfg(test)]
@@ -106,9 +114,11 @@ mod tests {
 
     #[test]
     fn test_cover_art_image() {
-        let path: String = String::from("somepath");
-        let coverart = coverart::init::init_coverart_only_path(path.clone());
+        let dir = String::from("./");
+        let filename = String::from("CoverArt.png");
+        let coverart = coverart::init::init_coverart_dir_and_filename(&dir, &filename);
 
-        assert_eq!(path, coverart.path);
+        assert_eq!(dir, coverart.directory);
+        assert_eq!(filename, coverart.filename);
     }
 }