phoenix/mear
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 2 Wiki Activity

jni memory leak fix

Browse Source
This commit is contained in:
kdeng00
2019-11-17 14:45:36 -05:00
parent 9bab2a7798
commit d584c6c3af
3 changed files with 13 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/src/main/cpp/Demo.cpp
+12 -2
View File
@@ -79,6 +79,12 @@ jobject songToObj(JNIEnv *env, const model::Song& song)
env->CallVoidMethod(songObj, songYear, year);
env->CallVoidMethod(songObj, songCoverArtId, coverArtId);
env->DeleteLocalRef(title);
env->DeleteLocalRef(album);
env->DeleteLocalRef(albumArtist);
env->DeleteLocalRef(artist);
env->DeleteLocalRef(genre);
return songObj;
}
@@ -290,8 +296,12 @@ Java_com_example_mear_repositories_TrackRepository_retrieveSongs(
auto allSongs = retrieveSongs(tk, uri);
jobjectArray songs = env->NewObjectArray(allSongs.size(), songClass, nullptr);
for (auto i = 0; i != allSongs.size(); ++i) {
auto song = songToObj(env, allSongs[i]);
env->SetObjectArrayElement(songs, i, song);
try {
auto song = songToObj(env, allSongs[i]);
env->SetObjectArrayElement(songs, i, song);
} catch (std::exception& ex) {
auto msg = ex.what();
}
}
return songs;