tsk-34: Fetch next ready scheduled message (#38)
Closes #34 Reviewed-on: phoenix/textsender-api#38 Co-authored-by: phoenix <kundeng00@pm.me> Co-committed-by: phoenix <kundeng00@pm.me>
This commit is contained in:
@@ -11,3 +11,4 @@ const AddEventToScheduledMessageEndpoint = "/api/v1/schedule/message/event"
|
||||
const GetScheduledMessageEventEndpoint = "/api/v1/schedule/message/event"
|
||||
const DeleteScheduledMessageEventEndpoint = "/api/v1/schedule/message/event/{id}"
|
||||
const UpdateScheduledMessageStatusEndpoint = "/api/v1/schedule/message/status/update"
|
||||
const FetchNextScheduledMessageEndpoint = "/api/v1/schedule/message/fetch"
|
||||
|
||||
@@ -29,6 +29,11 @@ type GetScheduledMessageResponse struct {
|
||||
Data []scheduling.ScheduledMessage `json:"data"`
|
||||
}
|
||||
|
||||
type FetchNextMessageResponse struct {
|
||||
Message string `json:"message"`
|
||||
Data []scheduling.ScheduledMessage `json:"data"`
|
||||
}
|
||||
|
||||
type ScheduledMessageHandler struct {
|
||||
ScheduledMessageStore store.ScheduledMessageStore
|
||||
}
|
||||
@@ -37,7 +42,7 @@ func NewScheduledMessageHandler(str store.ScheduledMessageStore) *ScheduledMessa
|
||||
return &ScheduledMessageHandler{ScheduledMessageStore: str}
|
||||
}
|
||||
|
||||
func (c *ScheduledMessageHandler) AddScheduledMessage(w http.ResponseWriter, r *http.Request) {
|
||||
func (s *ScheduledMessageHandler) AddScheduledMessage(w http.ResponseWriter, r *http.Request) {
|
||||
if r.Method != http.MethodPost {
|
||||
http.Error(w, "Method not allowed", http.StatusMethodNotAllowed)
|
||||
return
|
||||
@@ -63,7 +68,7 @@ func (c *ScheduledMessageHandler) AddScheduledMessage(w http.ResponseWriter, r *
|
||||
if validStatus, err := IsStatusValid(&scheduledMessage); err == nil {
|
||||
if validStatus {
|
||||
if valid, err := isScheduledTimeValid(&scheduledMessage); err == nil && valid {
|
||||
if err = c.ScheduledMessageStore.CreateScheduledMessage(ctx, &scheduledMessage); err == nil {
|
||||
if err = s.ScheduledMessageStore.CreateScheduledMessage(ctx, &scheduledMessage); err == nil {
|
||||
statusCode = http.StatusCreated
|
||||
resp.Data = append(resp.Data, scheduledMessage)
|
||||
resp.Message = "Successful"
|
||||
@@ -88,7 +93,7 @@ func (c *ScheduledMessageHandler) AddScheduledMessage(w http.ResponseWriter, r *
|
||||
RespondWithJSON(w, statusCode, &resp)
|
||||
}
|
||||
|
||||
func (c *ScheduledMessageHandler) GetScheduledMessage(w http.ResponseWriter, r *http.Request) {
|
||||
func (s *ScheduledMessageHandler) GetScheduledMessage(w http.ResponseWriter, r *http.Request) {
|
||||
var id, userId uuid.UUID
|
||||
|
||||
if idParam, err := ParseQueryParams(r, "id"); err == nil {
|
||||
@@ -115,7 +120,7 @@ func (c *ScheduledMessageHandler) GetScheduledMessage(w http.ResponseWriter, r *
|
||||
http.Error(w, "Invalid query parameters", http.StatusBadRequest)
|
||||
return
|
||||
} else if userId != uuid.Nil && id != uuid.Nil {
|
||||
if schMsgs, err := c.ScheduledMessageStore.GetWithUserId(ctx, userId); err != nil {
|
||||
if schMsgs, err := s.ScheduledMessageStore.GetWithUserId(ctx, userId); err != nil {
|
||||
statusCode = http.StatusInternalServerError
|
||||
resp.Message = err.Error()
|
||||
} else {
|
||||
@@ -128,7 +133,7 @@ func (c *ScheduledMessageHandler) GetScheduledMessage(w http.ResponseWriter, r *
|
||||
resp.Message = "Successful"
|
||||
}
|
||||
} else if id != uuid.Nil {
|
||||
if schMsg, err := c.ScheduledMessageStore.Get(ctx, id); err != nil {
|
||||
if schMsg, err := s.ScheduledMessageStore.Get(ctx, id); err != nil {
|
||||
statusCode = http.StatusInternalServerError
|
||||
resp.Message = err.Error()
|
||||
} else {
|
||||
@@ -137,7 +142,7 @@ func (c *ScheduledMessageHandler) GetScheduledMessage(w http.ResponseWriter, r *
|
||||
resp.Data = append(resp.Data, *schMsg)
|
||||
}
|
||||
} else {
|
||||
if schMsgs, err := c.ScheduledMessageStore.GetWithUserId(ctx, userId); err != nil {
|
||||
if schMsgs, err := s.ScheduledMessageStore.GetWithUserId(ctx, userId); err != nil {
|
||||
statusCode = http.StatusInternalServerError
|
||||
resp.Message = err.Error()
|
||||
} else {
|
||||
@@ -152,6 +157,28 @@ func (c *ScheduledMessageHandler) GetScheduledMessage(w http.ResponseWriter, r *
|
||||
RespondWithJSON(w, statusCode, &resp)
|
||||
}
|
||||
|
||||
func (s *ScheduledMessageHandler) FetchNextMessage(w http.ResponseWriter, r *http.Request) {
|
||||
ctx := r.Context()
|
||||
var resp FetchNextMessageResponse
|
||||
var statusCode int
|
||||
|
||||
if schMsg, err := s.ScheduledMessageStore.FetchNextScheduledMessage(ctx); err != nil {
|
||||
statusCode = http.StatusInternalServerError
|
||||
resp.Message = err.Error()
|
||||
} else {
|
||||
if schMsg != nil {
|
||||
statusCode = http.StatusOK
|
||||
resp.Message = "Successful"
|
||||
resp.Data = append(resp.Data, *schMsg)
|
||||
} else {
|
||||
statusCode = http.StatusNotFound
|
||||
resp.Message = "No item"
|
||||
}
|
||||
}
|
||||
|
||||
RespondWithJSON(w, statusCode, &resp)
|
||||
}
|
||||
|
||||
func isScheduledTimeValid(schMsg *scheduling.ScheduledMessage) (bool, error) {
|
||||
now := time.Now()
|
||||
timeCutOff := now.Add(-5 * time.Minute)
|
||||
|
||||
@@ -115,7 +115,6 @@ func TestGetScheduledMessageEventWithMock(t *testing.T) {
|
||||
}
|
||||
|
||||
url := fmt.Sprintf("%s?id=%s", endpoint.GetScheduledMessageEventEndpoint, event.Id.String())
|
||||
fmt.Println("Url:", url)
|
||||
req, _ := http.NewRequest("GET", url, nil)
|
||||
rr := httptest.NewRecorder()
|
||||
|
||||
|
||||
@@ -78,6 +78,57 @@ func TestGetScheduledMessageWithMock(t *testing.T) {
|
||||
assert.NoError(t, err, "Error parsing response %v", err)
|
||||
}
|
||||
|
||||
func TestFetchScheduledMessageWithMock(t *testing.T) {
|
||||
now := time.Now()
|
||||
mockStore := mock.NewMockScheduledMessageStore()
|
||||
contactStore := mock.NewMockContactStore()
|
||||
messageStore := mock.NewMockMessageStore()
|
||||
schMsgEventStore := mock.NewMockScheduledMessageEventStore()
|
||||
|
||||
recipientId := uuid.New()
|
||||
messageId := uuid.New()
|
||||
scheduledMessageId := uuid.New()
|
||||
testUserId := uuid.New()
|
||||
|
||||
con := testContact(recipientId, testUserId)
|
||||
msg := testMessage(messageId, testUserId)
|
||||
schMsg := testScheduledMessage(scheduledMessageId, testUserId, now)
|
||||
event := testScheduledMessageEvent(msg.Id, con.Id, schMsg.Id)
|
||||
|
||||
ctx := t.Context()
|
||||
|
||||
if err := contactStore.CreateContact(ctx, &con); err != nil {
|
||||
assert.NoError(t, err, "Error creating contact: %v", err)
|
||||
} else if err = messageStore.CreateMessage(ctx, &msg); err != nil {
|
||||
assert.NoError(t, err, "Error creating message: %v", err)
|
||||
} else if err = mockStore.CreateScheduledMessage(ctx, &schMsg); err != nil {
|
||||
assert.NoError(t, err, "Error creating scheduled message: %v", err)
|
||||
} else if err = schMsgEventStore.CreateScheduledMessageEvent(ctx, &event); err != nil {
|
||||
assert.NoError(t, err, "Error creating scheduled message event: %v", err)
|
||||
} else if newStatus, err := mockStore.UpdateStatus(ctx, schMsg.Id, scheduling.Ready); err != nil {
|
||||
assert.NoError(t, err, "Error updating status: %v", err)
|
||||
} else {
|
||||
assert.Equal(t, *newStatus, scheduling.Ready)
|
||||
}
|
||||
|
||||
req, _ := http.NewRequest("GET", endpoint.FetchNextScheduledMessageEndpoint, nil)
|
||||
rr := httptest.NewRecorder()
|
||||
|
||||
handler := NewScheduledMessageHandler(mockStore)
|
||||
handler.FetchNextMessage(rr, req)
|
||||
|
||||
assert.Equal(t, http.StatusOK, rr.Code)
|
||||
|
||||
var response FetchNextMessageResponse
|
||||
err := json.Unmarshal(rr.Body.Bytes(), &response)
|
||||
assert.NoError(t, err, "Error fetching scheduled message: %v", err)
|
||||
|
||||
assert.NotEmpty(t, response.Data, "No data")
|
||||
|
||||
fetchedSchMsg := response.Data[0]
|
||||
assert.Equal(t, scheduling.Processing, fetchedSchMsg.Status, "The statuses do not match")
|
||||
}
|
||||
|
||||
func testCreateScheduledMessageRequest(userId uuid.UUID, now time.Time) CreateScheduledMessageRequest {
|
||||
scheduled := now.Add(5 * time.Minute)
|
||||
return CreateScheduledMessageRequest{Status: scheduling.Pending, UserId: userId, Scheduled: scheduled}
|
||||
|
||||
Reference in New Issue
Block a user