UserProfile (#1)

Reviewed-on: phoenix/textsender-models#1

.gitea/workflows/tag_release.yaml

@@ -25,7 +25,7 @@ jobs:
         run: |
           echo "Creating version"
 
-          VERSION="0.2.2"
+          VERSION="0.2.3"
           PROJECT_COMMIT_HASH=$(git rev-parse HEAD | cut -c 1-10)
           BRANCH_REF="${{ gitea.ref }}"
           BRANCH_NAME=$(echo "$BRANCH_REF" | cut -d '/' -f 3)

tx0/user/user.go

@@ -7,12 +7,14 @@ import (
 )
 
 type User struct {
-	Id          uuid.UUID  `json:"id"`
+	Id          uuid.UUID `json:"id"`
-	PhoneNumber string     `json:"phone_number"`
+	PhoneNumber string    `json:"phone_number"`
-	Username    string     `json:"username"`
+	Username    string    `json:"username"`
-	Password    string     `json:"password"`
+	Password    string    `json:"password"`
-	Firstname   *string    `json:"first_name,omitempty"`
+	// Firstname is a pointer
-	Lastname    *string    `json:"last_name,omitempty"`
+	Firstname *string `json:"first_name,omitempty"`
-	Created     time.Time  `json:"created"`
+	// Lastname is a pointer
-	LastLogin   *time.Time `json:"last_login,omitempty"`
+	Lastname  *string    `json:"last_name,omitempty"`
+	Created   time.Time  `json:"created"`
+	LastLogin *time.Time `json:"last_login,omitempty"`
 }

tx0/user/user_profile.go

@@ -2,11 +2,19 @@ package user
 
 import (
 	"fmt"
+	"time"
+
+	"github.com/google/uuid"
 )
 
-// TODO: Replace Usr with all the fields from User, except Password and other sensitive fields
 type UserProfile struct {
-	Usr *User `json:"user"`
+	UserId      uuid.UUID  `json:"user_id"`
+	PhoneNumber string     `json:"phone_number"`
+	Username    string     `json:"username"`
+	Firstname   *string    `json:"firstname,omitempty"`
+	Lastname    *string    `json:"lastname,omitempty"`
+	Created     time.Time  `json:"created"`
+	LastLogin   *time.Time `json:"last_login,omitempty"`
 }
 
 func InitUserProfile(usr *User) (usrProfile *UserProfile, err error) {
@@ -14,14 +22,20 @@ func InitUserProfile(usr *User) (usrProfile *UserProfile, err error) {
 		return nil, fmt.Errorf("User is empty")
 	} else {
 		usrProfile = new(UserProfile)
-		if len(usr.Password) > 0 {
+		usrProfile.UserId = usr.Id
-			newUsr := User{Id: usr.Id, PhoneNumber: usr.PhoneNumber, Username: usr.Username, Firstname: usr.Firstname, Lastname: usr.Lastname, Created: usr.Created, LastLogin: usr.LastLogin}
+		usrProfile.PhoneNumber = usr.PhoneNumber
-			usrProfile.Usr = &newUsr
+		usrProfile.Username = usr.Username
-
+		if usr.Firstname != nil {
-			return usrProfile, nil
+			usrProfile.Firstname = usr.Firstname
-		} else {
-			usrProfile.Usr = usr
-			return usrProfile, nil
 		}
+		if usr.Lastname != nil {
+			usrProfile.Lastname = usr.Lastname
+		}
+		usrProfile.Created = usr.Created
+		if usr.LastLogin != nil {
+			usrProfile.LastLogin = usr.LastLogin
+		}
+
+		return usrProfile, nil
 	}
 }

tx0/user/user_profile_test.go

@@ -13,6 +13,4 @@ func TestInitUserProfile(t *testing.T) {
 
 	assert.NoError(t, err, "Error %v", err)
 	assert.NotEmpty(t, profile, "UserProfile is empty")
-
-	assert.Empty(t, profile.Usr.Password, "Password should be empty")
 }