tsk-68: Code formatting

Reviewed-on: #69
Co-authored-by: phoenix <kundeng00@pm.me>
Co-committed-by: phoenix <kundeng00@pm.me>

Cargo.lock

@@ -520,8 +520,8 @@ dependencies = [
 
 [[package]]
 name = "icarus_models"
-version = "0.8.0"
+version = "0.9.2"
-source = "git+ssh://git@git.kundeng.us/phoenix/icarus_models.git?tag=v0.8.0#860d684e7b340b05d43d1fc3e6bd36b7cc45d81b"
+source = "git+ssh://git@git.kundeng.us/phoenix/icarus_models.git?tag=v0.9.2#05525618514409101c1d6474dafb201386d14a30"
 dependencies = [
  "josekit",
  "rand",
@@ -1322,7 +1322,7 @@ dependencies = [
 
 [[package]]
 name = "songparser"
-version = "0.4.9"
+version = "0.4.11"
 dependencies = [
  "futures",
  "icarus_envy",

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "songparser"
-version = "0.4.9"
+version = "0.4.11"
 edition = "2024"
 rust-version = "1.90"
 
@@ -14,5 +14,5 @@ time = { version = "0.3.44", features = ["macros", "serde"] }
 uuid = { version = "1.18.1", features = ["v4", "serde"] }
 rand = { version = "0.9.2" }
 icarus_meta = { git = "ssh://git@git.kundeng.us/phoenix/icarus_meta.git", tag = "v0.4.3" }
-icarus_models = { git = "ssh://git@git.kundeng.us/phoenix/icarus_models.git", tag = "v0.8.0" }
+icarus_models = { git = "ssh://git@git.kundeng.us/phoenix/icarus_models.git", tag = "v0.9.2" }
 icarus_envy = { git = "ssh://git@git.kundeng.us/phoenix/icarus_envy.git", tag = "v0.5.0" }

src/api.rs

@@ -1,5 +1,4 @@
 pub mod fetch_next_queue_item {
-
     pub async fn fetch_next_queue_item(
         app: &crate::config::App,
     ) -> Result<reqwest::Response, reqwest::Error> {
@@ -12,9 +11,7 @@ pub mod fetch_next_queue_item {
     }
 
     pub mod response {
-        use serde::{Deserialize, Serialize};
+        #[derive(Debug, serde::Deserialize, serde::Serialize)]
-
-        #[derive(Debug, Deserialize, Serialize)]
         pub struct QueueItem {
             pub id: uuid::Uuid,
             pub filename: String,
@@ -22,7 +19,7 @@ pub mod fetch_next_queue_item {
             pub user_id: uuid::Uuid,
         }
 
-        #[derive(Debug, Deserialize, Serialize)]
+        #[derive(Debug, serde::Deserialize, serde::Serialize)]
         pub struct SongQueueItem {
             pub message: String,
             pub data: Vec<QueueItem>,

src/parser/mod.rs

@@ -107,9 +107,10 @@ pub async fn prep_song(
                     let song = icarus_models::song::Song {
                         directory: icarus_envy::environment::get_root_directory().await.value,
                         filename: icarus_models::song::generate_filename(
-                            icarus_models::types::MusicTypes::FlacExtension,
+                            icarus_models::types::MusicType::FlacExtension,
                             true,
-                        ),
+                        )
+                        .unwrap(),
                         data: song_bytes,
                         ..Default::default()
                     };
@@ -139,80 +140,117 @@ pub async fn prep_song(
                                 .await
                             {
                                 Ok(response) => {
-                                    let id = &response.data[0].id;
+                                    let bod = &response.data[0];
-                                    let created_at = &response.data[0].created_at;
+                                    match process_coverart(app, &queued_song.id, bod).await {
-                                    let metadata = &response.data[0].metadata;
+                                        Ok(qc) => Ok((queued_song, qc, bod.metadata.clone())),
+                                        Err(err) => Err(err),
+                                    }
+                                }
+                                Err(err) => Err(err),
+                            }
+                        }
+                        Err(err) => Err(err),
+                    }
+                }
+                Err(err) => Err(err),
+            }
+        }
+        Err(err) => Err(err),
+    }
+}
+
+pub async fn process_coverart(
+    app: &crate::config::App,
+    queued_song_id: &uuid::Uuid,
+    queued_item: &crate::api::get_metadata_queue::response::QueueItem,
+) -> Result<crate::queued_item::QueuedCoverArt, reqwest::Error> {
+    let id = queued_item.id;
+    let created_at = queued_item.created_at;
+    let metadata = &queued_item.metadata;
     println!("Id: {id:?}");
     println!("Metadata: {metadata:?}");
     println!("Created at: {created_at:?}");
 
     println!("Getting coverart queue");
-                                    match crate::api::get_coverart_queue::get(app, &queued_song.id).await {
+    match crate::api::get_coverart_queue::get(app, queued_song_id).await {
         Ok(response) => {
-                                            match response.json::<crate::api::get_coverart_queue::response::Response>().await {
+            match response
+                .json::<crate::api::get_coverart_queue::response::Response>()
+                .await
+            {
                 Ok(response) => {
                     let coverart_queue = &response.data[0];
                     let coverart_queue_id = coverart_queue.id;
                     println!("Coverart queue Id: {coverart_queue_id:?}");
 
                     match crate::api::get_coverart_queue::get_data(app, &coverart_queue_id).await {
-                                                        Ok(response) => match crate::api::parsing::parse_response_into_bytes(response).await {
+                        Ok(response) => {
+                            match crate::api::parsing::parse_response_into_bytes(response).await {
                                 Ok(coverart_queue_bytes) => {
-                                                                let (directory, filename) = crate::util::generate_coverart_queue_dir_and_filename(&coverart_queue.file_type).await;
+                                    let queued_coverart = init_queued_coverart(
+                                        &coverart_queue_id,
+                                        &coverart_queue.file_type,
+                                        coverart_queue_bytes,
+                                    )
+                                    .await;
+                                    println!(
+                                        "Saved coverart queue file at: {:?}",
+                                        queued_coverart.path
+                                    );
+                                    println!(
+                                        "Queued CoverArt file type: {:?}",
+                                        queued_coverart.coverart.file_type
+                                    );
+
+                                    Ok(queued_coverart)
+                                }
+                                Err(err) => Err(err),
+                            }
+                        }
+                        Err(err) => Err(err),
+                    }
+                }
+                Err(err) => Err(err),
+            }
+        }
+        Err(err) => Err(err),
+    }
+}
+
+async fn init_queued_coverart(
+    coverart_queue_id: &uuid::Uuid,
+    file_type: &str,
+    bytes: Vec<u8>,
+) -> crate::queued_item::QueuedCoverArt {
+    // TODO: Consider separating song and coverart when saving to the filesystem
+    let covart_type = if file_type == icarus_meta::detection::coverart::constants::PNG_TYPE {
+        icarus_models::types::CoverArtType::PngExtension
+    } else if file_type == icarus_meta::detection::coverart::constants::JPEG_TYPE {
+        icarus_models::types::CoverArtType::JpegExtension
+    } else if file_type == icarus_meta::detection::coverart::constants::JPG_TYPE {
+        icarus_models::types::CoverArtType::JpgExtension
+    } else {
+        icarus_models::types::CoverArtType::None
+    };
     let coverart = icarus_models::coverart::CoverArt {
-                                                                    directory,
+        directory: icarus_envy::environment::get_root_directory().await.value,
-                                                                    filename,
+        filename: match icarus_models::coverart::generate_filename(covart_type, true) {
-                                                                    data: coverart_queue_bytes,
+            Ok(filename) => filename,
+            Err(err) => {
+                eprintln!("Error generating CoverArt filename: {err:?}");
+                panic!("Error initializing queued CoverArt");
+            }
+        },
+        file_type: String::from(file_type),
+        data: bytes,
         ..Default::default()
     };
     coverart.save_to_filesystem().unwrap();
-                                                                let coverart_queue_fs_path = match coverart.get_path() {
+    let coverart_queue_fs_path = coverart.get_path().unwrap();
-                                                                    Ok(path) => {
+    crate::queued_item::QueuedCoverArt {
-                                                                        path
+        id: *coverart_queue_id,
-                                                                    }
-                                                                    Err(err) => {
-                                                                        eprintln!("Error: {err:?}");
-                                                                        std::process::exit(-1);
-                                                                    }
-                                                                };
-
-                                                                let queued_coverart = crate::queued_item::QueuedCoverArt {
-                                                                    id: coverart_queue_id,
         coverart,
-                                                                    path: coverart_queue_fs_path
+        path: coverart_queue_fs_path,
-                                                                };
-
-                                                                println!("Saved coverart queue file at: {:?}", queued_coverart.path);
-
-                                                                Ok((queued_song, queued_coverart, metadata.clone()))
-                                                            }
-                                                            Err(err) => {
-                                                                Err(err)
-                                                            }
-                                                        }
-                                                        Err(err) => {
-                                                            Err(err)
-                                                        }
-                                                    }
-                                                }
-                                                Err(err) => {
-                                                    Err(err)
-                                                }
-                                            }
-                                        }
-                                        Err(err) => Err(err),
-                                    }
-                                }
-                                Err(err) => Err(err),
-                            }
-                        }
-                        Err(err) => Err(err),
-                    }
-                }
-                Err(err) => Err(err),
-            }
-        }
-        Err(err) => Err(err),
     }
 }
 

src/util.rs

@@ -4,39 +4,3 @@ pub fn path_buf_to_string(path: &std::path::Path) -> String {
         None => String::new(),
     }
 }
-
-// TODO: Consider having something like this in icarus_models
-pub async fn generate_coverart_queue_dir_and_filename(file_type: &str) -> (String, String) {
-    use rand::Rng;
-
-    let mut filename: String = String::new();
-    let filename_len = 10;
-
-    let some_chars: String = String::from("abcdefghij0123456789");
-    let mut rng = rand::rng();
-
-    for _ in 0..filename_len {
-        let random_number: i32 = rng.random_range(0..=19);
-        let index = random_number as usize;
-        let rando_char = some_chars.chars().nth(index);
-
-        if let Some(c) = rando_char {
-            filename.push(c);
-        }
-    }
-
-    filename += if file_type == icarus_meta::detection::coverart::constants::JPEG_TYPE
-        || file_type == icarus_meta::detection::coverart::constants::JPG_TYPE
-    {
-        icarus_models::constants::file_extensions::image::JPEGEXTENSION
-    } else if file_type == icarus_meta::detection::coverart::constants::PNG_TYPE {
-        icarus_models::constants::file_extensions::image::PNGEXTENSION
-    } else {
-        ""
-    };
-
-    // TODO: Consider separating song and coverart when saving to the filesystem
-    let directory = icarus_envy::environment::get_root_directory().await.value;
-
-    (directory, filename)
-}