refactor (#24)
All checks were successful
Rust Build / Check (push) Successful in 37s
Rust Build / Check (pull_request) Successful in 31s
Release Tagging / release (push) Successful in 41s
Rust Build / Test Suite (push) Successful in 41s
Rust Build / Rustfmt (push) Successful in 31s
Rust Build / Clippy (push) Successful in 38s
Rust Build / build (push) Successful in 42s
Rust Build / Test Suite (pull_request) Successful in 37s
Rust Build / Rustfmt (pull_request) Successful in 33s
Rust Build / Clippy (pull_request) Successful in 33s
Rust Build / build (pull_request) Successful in 43s

Reviewed-on: #24
Co-authored-by: phoenix <kundeng00@pm.me>
Co-committed-by: phoenix <kundeng00@pm.me>
This commit is contained in:
2025-04-19 01:31:57 +00:00
committed by phoenix
parent c80bc7d7e1
commit f534687292
3 changed files with 102 additions and 90 deletions

View File

@@ -1,6 +1,6 @@
[package]
name = "icarus_meta"
version = "0.1.11"
version = "0.1.20"
edition = "2024"
rust-version = "1.86"

View File

@@ -1,20 +1,3 @@
use lofty::{file::AudioFile, tag::Accessor};
use crate::types;
fn get_type(t: types::Type) -> Result<String, std::io::Error> {
match t {
types::Type::Title => Ok("TITLE".to_owned()),
types::Type::Artist => Ok("ARTIST".to_owned()),
types::Type::Album => Ok("ALBUM".to_owned()),
types::Type::AlbumArtist => Ok("ALBUMARTIST".to_owned()),
types::Type::Genre => Ok("GENRE".to_owned()),
types::Type::Date => Ok("DATE".to_owned()),
types::Type::Track => Ok("TRACKNUMBER".to_owned()),
types::Type::Disc => Ok("DISCNUMBER".to_owned()),
}
}
pub mod coverart {
use lofty::{file::AudioFile, ogg::OggPictureStorage};
@@ -151,90 +134,100 @@ pub mod coverart {
}
}
pub fn get_meta(t: types::Type, filepath: &String) -> Result<String, std::io::Error> {
match std::fs::File::open(filepath) {
Ok(mut content) => {
match lofty::flac::FlacFile::read_from(&mut content, lofty::config::ParseOptions::new())
{
Ok(flac_file) => match flac_file.vorbis_comments() {
Some(vb) => {
let type_str: String = get_type(t).unwrap();
match vb.get(&type_str) {
Some(val) => Ok(val.to_owned()),
None => Err(std::io::Error::new(
std::io::ErrorKind::InvalidData,
"Could not get tag data",
)),
pub mod metadata {
use crate::types;
use lofty::file::AudioFile;
use lofty::tag::Accessor;
pub fn get_meta(t: types::Type, filepath: &String) -> Result<String, std::io::Error> {
match std::fs::File::open(filepath) {
Ok(mut content) => {
match lofty::flac::FlacFile::read_from(
&mut content,
lofty::config::ParseOptions::new(),
) {
Ok(flac_file) => match flac_file.vorbis_comments() {
Some(vb) => {
let type_str: String = types::access::get_type(t).unwrap();
match vb.get(&type_str) {
Some(val) => Ok(val.to_owned()),
None => Err(std::io::Error::new(
std::io::ErrorKind::InvalidData,
"Could not get tag data",
)),
}
}
}
None => Err(std::io::Error::new(
None => Err(std::io::Error::new(
std::io::ErrorKind::InvalidData,
"No tags found",
)),
},
Err(err) => Err(std::io::Error::new(
std::io::ErrorKind::InvalidData,
"No tags found",
err.to_string(),
)),
},
Err(err) => Err(std::io::Error::new(
std::io::ErrorKind::InvalidData,
err.to_string(),
)),
}
}
Err(err) => Err(err),
}
Err(err) => Err(err),
}
}
pub fn set_meta(
t: types::Type,
filepath: &String,
value: &String,
) -> Result<String, std::io::Error> {
match std::fs::File::open(filepath) {
Ok(mut content) => {
match lofty::flac::FlacFile::read_from(&mut content, lofty::config::ParseOptions::new())
{
Ok(mut flac_file) => match flac_file.vorbis_comments_mut() {
Some(vb) => {
let pre_value = value.clone();
match t {
types::Type::Album => {
vb.set_album(pre_value);
}
types::Type::AlbumArtist => {
vb.insert(get_type(t).unwrap(), pre_value);
}
types::Type::Artist => {
vb.set_artist(pre_value);
}
types::Type::Date => {
vb.insert(get_type(t).unwrap(), pre_value);
}
types::Type::Disc => {
vb.set_disk(pre_value.parse().unwrap());
}
types::Type::Genre => {
vb.set_genre(pre_value);
}
types::Type::Title => {
vb.set_title(pre_value);
}
types::Type::Track => {
vb.set_track(pre_value.parse().unwrap());
}
};
pub fn set_meta(
t: types::Type,
filepath: &String,
value: &String,
) -> Result<String, std::io::Error> {
match std::fs::File::open(filepath) {
Ok(mut content) => {
match lofty::flac::FlacFile::read_from(
&mut content,
lofty::config::ParseOptions::new(),
) {
Ok(mut flac_file) => match flac_file.vorbis_comments_mut() {
Some(vb) => {
let pre_value = value.clone();
match t {
types::Type::Album => {
vb.set_album(pre_value);
}
types::Type::AlbumArtist => {
vb.insert(types::access::get_type(t).unwrap(), pre_value);
}
types::Type::Artist => {
vb.set_artist(pre_value);
}
types::Type::Date => {
vb.insert(types::access::get_type(t).unwrap(), pre_value);
}
types::Type::Disc => {
vb.set_disk(pre_value.parse().unwrap());
}
types::Type::Genre => {
vb.set_genre(pre_value);
}
types::Type::Title => {
vb.set_title(pre_value);
}
types::Type::Track => {
vb.set_track(pre_value.parse().unwrap());
}
};
Ok(value.to_owned())
}
None => Err(std::io::Error::new(
Ok(value.to_owned())
}
None => Err(std::io::Error::new(
std::io::ErrorKind::InvalidData,
"No tags found",
)),
},
Err(err) => Err(std::io::Error::new(
std::io::ErrorKind::InvalidData,
"No tags found",
err.to_string(),
)),
},
Err(err) => Err(std::io::Error::new(
std::io::ErrorKind::InvalidData,
err.to_string(),
)),
}
}
Err(err) => Err(err),
}
Err(err) => Err(err),
}
}
@@ -315,6 +308,7 @@ mod tests {
}
mod get {
use super::metadata::get_meta;
use super::*;
use crate::types;
@@ -519,7 +513,9 @@ mod tests {
}
mod set {
use super::metadata::{get_meta, set_meta};
use super::*;
use crate::types;
#[test]
fn test_set_title() {

View File

@@ -8,3 +8,19 @@ pub enum Type {
Track,
Disc,
}
pub mod access {
pub fn get_type(t: super::Type) -> Result<String, std::io::Error> {
match t {
super::Type::Title => Ok("TITLE".to_owned()),
super::Type::Artist => Ok("ARTIST".to_owned()),
super::Type::Album => Ok("ALBUM".to_owned()),
super::Type::AlbumArtist => Ok("ALBUMARTIST".to_owned()),
super::Type::Genre => Ok("GENRE".to_owned()),
super::Type::Date => Ok("DATE".to_owned()),
super::Type::Track => Ok("TRACKNUMBER".to_owned()),
super::Type::Disc => Ok("DISCNUMBER".to_owned()),
}
}
}