Merge pull request 'devel' (#16) from devel into main

Reviewed-on: phoenix/icarus-models#16

.gitea/workflows/tag_release.yaml

@@ -3,13 +3,14 @@ name: Release Tagging
 on:
   push:
     branches:
+      - main
       - devel
     tags:
       - 'v*' # Trigger on tags matching v*
 
 jobs:
   release:
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     steps:
       - name: Checkout code
         uses: actions/checkout@v3

.gitea/workflows/workflow.yaml

@@ -13,7 +13,7 @@ on:
 jobs:
   check:
     name: Check
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
       - uses: actions-rust-lang/setup-rust-toolchain@v1
@@ -23,7 +23,7 @@ jobs:
 
   test:
     name: Test Suite
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
       - uses: actions-rust-lang/setup-rust-toolchain@v1
@@ -33,7 +33,7 @@ jobs:
 
   fmt:
     name: Rustfmt
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
       - uses: actions-rust-lang/setup-rust-toolchain@v1
@@ -44,7 +44,7 @@ jobs:
 
   clippy:
     name: Clippy
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
       - uses: actions-rust-lang/setup-rust-toolchain@v1
@@ -55,7 +55,7 @@ jobs:
 
   build:
     name: build
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
       - uses: actions-rust-lang/setup-rust-toolchain@v1

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
-name = "icarus_models"
-version = "0.3.0"
+name = "icarus-models"
+version = "0.1.14"
 edition = "2024"
 description = "models used for the icarus project"
 license = "MIT"
@@ -9,6 +9,4 @@ license = "MIT"
 serde = { version = "1.0.218", features = ["derive"] }
 serde_json = { version = "1.0.139" }
 rand = { version = "0.9" }
-uuid = { version = "1.16.0", features = ["v4", "serde"] }
-[dev-dependencies]
 tempfile = { version = "3.19.1" }

src/access_level.rs

@@ -4,34 +4,34 @@ use serde::{Deserialize, Serialize};
 
 #[derive(Clone, Debug, Deserialize, Serialize)]
 pub struct AccessLevel {
-    pub id: uuid::Uuid,
+    pub id: i32,
     pub level: String,
-    pub song_id: uuid::Uuid,
+    pub song_id: i32,
 }
 
 impl Default for AccessLevel {
     fn default() -> Self {
         AccessLevel {
-            id: uuid::Uuid::new_v4(),
+            id: -1,
             level: String::new(),
-            song_id: uuid::Uuid::new_v4(),
+            song_id: -1,
         }
     }
 }
 
 pub fn default_level() -> AccessLevel {
     AccessLevel {
-        id: uuid::Uuid::new_v4(),
+        id: -1,
         level: String::from("Public"),
-        song_id: uuid::Uuid::new_v4(),
+        song_id: -1,
     }
 }
 
 pub fn private_level() -> AccessLevel {
     AccessLevel {
-        id: uuid::Uuid::new_v4(),
+        id: -1,
         level: String::from("Private"),
-        song_id: uuid::Uuid::new_v4(),
+        song_id: -1,
     }
 }
 

src/album.rs

@@ -5,7 +5,9 @@ pub mod collection {
     use std::fs::File;
     use std::io::BufReader;
 
-    use crate::init;
+    fn is_set(num: &i32) -> bool {
+        *num >= 0
+    }
 
     pub fn parse_album(filepath: &String) -> Result<Album, serde_json::Error> {
         let file = File::open(filepath).expect("Failed to open file");
@@ -25,7 +27,7 @@ pub mod collection {
         pub genre: String,
         pub year: i32,
         pub track_count: i32,
-        #[serde(skip_serializing_if = "init::is_set")]
+        #[serde(skip_serializing_if = "is_set")]
         pub disc_count: i32,
         #[serde(skip_serializing_if = "Vec::is_empty")]
         pub tracks: Vec<Track>,

src/constants.rs

@@ -1,14 +1,5 @@
-pub mod file_extensions {
-    pub mod audio {
-        pub const DEFAULTMUSICEXTENSION: &str = FLACEXTENSION;
-        pub const FLACEXTENSION: &str = ".flac";
-        pub const WAVEXTENSION: &str = ".wav";
-        pub const MPTHREEEXTENSION: &str = ".mp3";
-    }
-
-    pub mod image {
-        pub const JPGEXTENSION: &str = ".jpg";
-        pub const JPEGEXTENSION: &str = ".jpeg";
-        pub const PNGEXTENSION: &str = ".png";
-    }
-}
+pub const DEFAULTMUSICEXTENSION: &str = FLACEXTENSION;
+pub const FLACEXTENSION: &str = ".flac";
+pub const WAVEXTENSION: &str = ".wav";
+pub const MPTHREEEXTENSION: &str = ".mp3";
+pub const JPGEXTENSION: &str = ".jpg";

src/coverart.rs

@@ -2,9 +2,9 @@ use std::io::Read;
 
 use serde::{Deserialize, Serialize};
 
-#[derive(Clone, Debug, Default, Deserialize, Serialize)]
+#[derive(Debug, Clone, Deserialize, Serialize)]
 pub struct CoverArt {
-    pub id: uuid::Uuid,
+    pub id: i32,
     pub title: String,
     pub path: String,
     pub data: Vec<u8>,

src/lib.rs

@@ -7,25 +7,3 @@ pub mod song;
 pub mod token;
 pub mod types;
 pub mod user;
-
-pub mod init {
-    pub fn is_id_valid(num: &i32) -> bool {
-        *num > 0
-    }
-
-    pub fn is_uuid_nil(uuid: &uuid::Uuid) -> bool {
-        uuid.is_nil()
-    }
-
-    pub fn is_zero(num: &i32) -> bool {
-        *num == 0
-    }
-
-    pub fn is_dur_not_set(num: &i32) -> bool {
-        *num == 0
-    }
-
-    pub fn is_set(num: &i32) -> bool {
-        *num >= 0
-    }
-}

src/login_result.rs

@@ -4,7 +4,7 @@ use serde::{Deserialize, Serialize};
 
 #[derive(Clone, Debug, Deserialize, Serialize)]
 pub struct LoginResult {
-    pub id: uuid::Uuid,
+    pub id: i32,
     pub username: String,
     pub token: String,
     #[serde(alias = "token_type")]
@@ -15,7 +15,7 @@ pub struct LoginResult {
 impl Default for LoginResult {
     fn default() -> Self {
         LoginResult {
-            id: uuid::Uuid::new_v4(),
+            id: -1,
             username: String::new(),
             token: String::new(),
             token_type: String::new(),

src/song.rs

@@ -1,7 +1,6 @@
 use std::io::Read;
 
 use crate::constants;
-use crate::init;
 use crate::types;
 
 use rand::Rng;
@@ -9,9 +8,9 @@ use serde::{Deserialize, Serialize};
 
 #[derive(Clone, Debug, Default, Deserialize, Serialize)]
 pub struct Song {
-    #[serde(skip_serializing_if = "init::is_uuid_nil")]
+    #[serde(skip_serializing_if = "is_zero")]
     #[serde(alias = "id")]
-    pub id: uuid::Uuid,
+    pub id: i32,
     #[serde(skip_serializing_if = "String::is_empty")]
     pub title: String,
     #[serde(skip_serializing_if = "String::is_empty")]
@@ -22,17 +21,17 @@ pub struct Song {
     pub album_artist: String,
     #[serde(skip_serializing_if = "String::is_empty")]
     pub genre: String,
-    #[serde(skip_serializing_if = "init::is_zero")]
+    #[serde(skip_serializing_if = "is_zero")]
     pub year: i32,
-    #[serde(skip_serializing_if = "init::is_dur_not_set")]
+    #[serde(skip_serializing_if = "is_dur_not_set")]
     pub duration: i32,
-    #[serde(skip_serializing_if = "init::is_zero")]
+    #[serde(skip_serializing_if = "is_zero")]
     pub track: i32,
-    #[serde(skip_serializing_if = "init::is_zero")]
+    #[serde(skip_serializing_if = "is_zero")]
     pub disc: i32,
-    #[serde(skip_serializing_if = "init::is_zero")]
+    #[serde(skip_serializing_if = "is_zero")]
     pub disc_count: i32,
-    #[serde(skip_serializing_if = "init::is_zero")]
+    #[serde(skip_serializing_if = "is_zero")]
     pub track_count: i32,
     #[serde(skip_serializing_if = "String::is_empty")]
     pub audio_type: String,
@@ -40,7 +39,7 @@ pub struct Song {
     pub date_created: String,
     #[serde(skip_serializing_if = "String::is_empty")]
     pub filename: String,
-    #[serde(skip_serializing_if = "init::is_zero")]
+    #[serde(skip_serializing_if = "is_zero")]
     pub user_id: i32,
     #[serde(skip)]
     pub data: Vec<u8>,
@@ -56,6 +55,14 @@ pub struct Song {
     // pub coverart_id: i32,
 }
 
+fn is_zero(num: &i32) -> bool {
+    *num == 0
+}
+
+fn is_dur_not_set(num: &i32) -> bool {
+    *num == 0
+}
+
 impl Song {
     pub fn to_metadata_json(&self, pretty: bool) -> Result<String, serde_json::Error> {
         if pretty {
@@ -121,18 +128,12 @@ impl Song {
 
         let file_extension = match typ {
             types::MusicTypes::DefaultMusicExtension => {
-                String::from(constants::file_extensions::audio::DEFAULTMUSICEXTENSION)
+                String::from(constants::DEFAULTMUSICEXTENSION)
             }
 
-            types::MusicTypes::WavExtension => {
-                String::from(constants::file_extensions::audio::WAVEXTENSION)
-            }
-            types::MusicTypes::FlacExtension => {
-                String::from(constants::file_extensions::audio::FLACEXTENSION)
-            }
-            types::MusicTypes::MPThreeExtension => {
-                String::from(constants::file_extensions::audio::MPTHREEEXTENSION)
-            }
+            types::MusicTypes::WavExtension => String::from(constants::WAVEXTENSION),
+            types::MusicTypes::FlacExtension => String::from(constants::FLACEXTENSION),
+            types::MusicTypes::MPThreeExtension => String::from(constants::MPTHREEEXTENSION),
         };
 
         if randomize {

src/token.rs

@@ -13,8 +13,8 @@ pub struct Token {
 
 #[derive(Clone, Debug, Deserialize, Serialize)]
 pub struct AccessToken {
-    #[serde(alias = "init::is_uuid_nil")]
-    pub user_id: uuid::Uuid,
+    #[serde(alias = "user_id")]
+    pub user_id: i32,
     #[serde(alias = "username")]
     pub username: String,
     #[serde(alias = "token")]

src/user.rs

@@ -1,13 +1,11 @@
 use std::default::Default;
 
-use crate::init;
-
 use serde::{Deserialize, Serialize};
 
 #[derive(Clone, Debug, Deserialize, Serialize)]
 pub struct User {
-    #[serde(skip_serializing_if = "init::is_uuid_nil")]
-    pub id: uuid::Uuid,
+    #[serde(skip_serializing_if = "is_id_valid")]
+    pub id: i32,
     #[serde(skip_serializing_if = "String::is_empty")]
     pub username: String,
     #[serde(skip_serializing_if = "String::is_empty")]
@@ -29,10 +27,14 @@ pub struct User {
     pub last_login: String,
 }
 
+fn is_id_valid(num: &i32) -> bool {
+    *num > 0
+}
+
 impl Default for User {
     fn default() -> Self {
         User {
-            id: uuid::Uuid::new_v4(),
+            id: -1,
             username: String::new(),
             password: String::new(),
             email: String::new(),